MDEV-39190 mariadb-dump --dump-slave outputs partial output for old servers#4945
Open
ParadoxV5 wants to merge 1 commit intoMDEV-37146from
Open
MDEV-39190 mariadb-dump --dump-slave outputs partial output for old servers#4945ParadoxV5 wants to merge 1 commit intoMDEV-37146from
ParadoxV5 wants to merge 1 commit intoMDEV-37146from
Conversation
…ervers When dumping from older servers, the MDEV-37146 optimization was clever to reuse the SHOW ALL SLAVES STATUS from an earlier step. But it forgot to rewind the tape before playing again, so it only saw a blank screen. It also left an extra “SHOW ALL SLAVES STATUS” text in dead code. This commit fixes both of these oversights.
bnestere
approved these changes
Apr 16, 2026
Contributor
bnestere
left a comment
bnestere
left a comment
There was a problem hiding this comment.
Looks good, thanks @ParadoxV5 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dumping from older servers, the MDEV-37146 optimization was clever to reuse the SHOW ALL SLAVES STATUS from an earlier step. But it forgot to rewind the tape before playing again, so it only saw a blank screen.
It also left an extra “SHOW ALL SLAVES STATUS” text in dead code.
This commit fixes both of these oversights.