Skip to content

fix: throws error instead of returning undefined (MAPCO-2988) #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
netanelC merged 2 commits into from
Mar 29, 2023
Merged

fix: throws error instead of returning undefined (MAPCO-2988) #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
550a3e3
fix: throws error instead of returning undefined
netanelC Mar 28, 2023
2a5e679
chore: removed undefined
netanelC Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/jobManagerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class JobManagerClient extends HttpClient {
}
}

public async getJob<T, P>(jobId: string, shouldReturnTasks = false): Promise<IJobResponse<T, P> | undefined> {
public async getJob<T, P>(jobId: string, shouldReturnTasks = false): Promise<IJobResponse<T, P>> {
const getJobUrl = this.getJobUrl(jobId);
try {
this.logger.debug({
Expand All @@ -96,7 +96,7 @@ export class JobManagerClient extends HttpClient {
msg: `failed to getJob for jobId=${jobId}`,
errorMessage: (err as { message: string }).message,
});
return undefined;
throw err;
Comment thread
asafMasa marked this conversation as resolved.
}
}

Expand Down