Brighter Fatter Correction Tutorial (using beam sim data)#94
Conversation
|
I can take an initial look, but someone at Princeton may be a better fit. I'll try to point the right person at it. |
…LSSTScienceCollaborations/StackClub into project/beamsim/andrewkbradshaw
|
Simon mentioned Josh Myers might like to review this tutorial - what do you think, @jmeyers314? |
|
I saw @jmeyers314 on the last day of the PCW, and he said he'd be happy to review @andrewkbradshaw 's beamsim B/F notebook. Assigning Josh as reviewer - thanks Josh! :-) |
|
I think I am finally done for now and it should be ready for a review @jmeyers314 |
…LSSTScienceCollaborations/StackClub into project/beamsim/andrewkbradshaw
jmeyers314
left a comment
There was a problem hiding this comment.
Looks good to me.
A few general comments.
• It looks like there are some spurious commits on this branch that probably belong elsewhere? Probably need to rebase this branch before merging it back to master.
• It would be nice to have some more context in places about why you're generating specific plots. It'd probably be nice to have these is dedicated markdown cells sprinkled throughout.
• Also, I think it'd be good to have a summary markdown cell at the bottom commenting on what you've learned from the various plots.
• (Finally, thanks to the rest of stack club for helping me review this!)
This will be added later
…LSSTScienceCollaborations/StackClub into project/beamsim/andrewkbradshaw
This isn't finished, but I think it is almost ready for feedback. I just need to make sure it runs on the data in /project/shared/beamsim/ . Then, I think the main thing I will need is some review by someone from the DM team. Would that be you @SimonKrughoff ?