Skip to content

add blending tutorials from LSST 2018 blending workshop#102

Merged
drphilmarshall merged 10 commits into
masterfrom
deblending
Aug 17, 2018
Merged

add blending tutorials from LSST 2018 blending workshop#102
drphilmarshall merged 10 commits into
masterfrom
deblending

Conversation

@fred3m
Copy link
Copy Markdown

@fred3m fred3m commented Aug 15, 2018

No description provided.

@fred3m fred3m requested a review from drphilmarshall August 15, 2018 16:25
@drphilmarshall
Copy link
Copy Markdown
Contributor

Sweet! Thanks so much, @fred3m . I'm going to add some extra pieces to the deblending branch directly, so you can see them. One is the standard Stack Club notebook header, which leads me to the question: are you OK with being listed as owner = maintainer of these notebooks? Another extra is a README for the Deblending folder, that shows the build status of each notebook. I think you'll like it! Cc-ing Sowmya Kamath @sowmyakth so we can thank her for her help in the production of these notebooks, and so she can check out the Stack Club repo. Thanks Sowmya!

@fred3m
Copy link
Copy Markdown
Author

fred3m commented Aug 15, 2018

Sure, you can list me as the owner/maintainer of the notebook. I'll also update the scarlet_tutorial notebook to describe how to load and access the data (which is included in the public testdata_deblender package). Unless there is a better dataset that science collaboration members are more likely to have access to.

@drphilmarshall
Copy link
Copy Markdown
Contributor

drphilmarshall commented Aug 15, 2018 via email

@fred3m
Copy link
Copy Markdown
Author

fred3m commented Aug 17, 2018

Ok, the notebook now points to /project/shared/data/testdata_deblender, which is the LSST package of test data that we used for the deblender.

Copy link
Copy Markdown
Contributor

@drphilmarshall drphilmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fred3m Thanks for fixing the data paths! I checked that both notebooks run all the way through with release w_2018_32. I guess they will fail the beavis-ci system test (which uses v16), but I think that's OK. Thanks again for providing these excellent tutorials! :-)

@drphilmarshall drphilmarshall merged commit 3fe7cdc into master Aug 17, 2018
@drphilmarshall drphilmarshall deleted the deblending branch September 6, 2018 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants