ci(e2e): disable matrix fail-fast; reduce stale-element noise#864
Open
PaulHax wants to merge 3 commits intoKitware:mainfrom
Open
ci(e2e): disable matrix fail-fast; reduce stale-element noise#864PaulHax wants to merge 3 commits intoKitware:mainfrom
PaulHax wants to merge 3 commits intoKitware:mainfrom
Conversation
…akes waitForViewCounts fetched WDIO element handles every 1s poll and called .length / .isExisting() on them; during layout remounts those handles went stale, producing WARN spam and occasional Timeout failures on macOS CI. Reading counts inside a single browser.execute avoids the handle round-trip entirely.
Same fix as waitForViewCounts: replace iteration over WDIO element handles with a single browser.execute. Eliminates the remaining 40 stale-element warnings per CI run originating from waitForViews (canvas.getAttribute on remounting views) and the four $$().length loops in session-state-lifecycle.e2e.ts.
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small improvements to E2E CI.
fail-fastin the matrix so a failure on one OS no longer cancels the other.waitForViews/waitForViewCountsand four similar polling loops insession-state-lifecycle.e2e.tsto query counts atomically viabrowser.execute. Eliminates ~40stale elementWARN messages per run and their flake risk.