Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
=======================================
Coverage ? 36.12%
=======================================
Files ? 32
Lines ? 1733
Branches ? 0
=======================================
Hits ? 626
Misses ? 1107
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
tolerance_precisiontoAnnotationBasicDimension. When omitted, the engine usesprecisionfor both the nominal dimension and its tolerance; an explicit override allows different decimal counts, including zero.Keep older commands valid and omit the new field from serialized output when unset. Includes regenerated OpenAPI and a regression test for old payloads and explicit zero.
Companion to https://github.com/KittyCAD/engine/pull/5298. The KCL follow-up will expose this as
tolerancePrecision.