Skip to content

Backport find_libpython.py changes from PyCall#203

Merged
tkf merged 2 commits into
JuliaPy:masterfrom
tkf:linked_libpython_windows
Oct 24, 2018
Merged

Backport find_libpython.py changes from PyCall#203
tkf merged 2 commits into
JuliaPy:masterfrom
tkf:linked_libpython_windows

Conversation

@tkf

@tkf tkf commented Sep 23, 2018

Copy link
Copy Markdown
Member

Edit: originally this PR was just for adding _linked_libpython_windows (#195) but I realized it'd probably be better to backport JuliaPy/PyCall.jl#556 here

@coveralls

coveralls commented Sep 23, 2018

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 499

  • 32 of 61 (52.46%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.5%) to 75.211%

Changes Missing Coverage Covered Lines Changed/Added Lines %
julia/find_libpython.py 32 61 52.46%
Files with Coverage Reduction New Missed Lines %
julia/find_libpython.py 3 73.42%
julia/core.py 5 80.66%
Totals Coverage Status
Change from base Build 497: -1.5%
Covered Lines: 446
Relevant Lines: 593

💛 - Coveralls

@tkf tkf changed the title Add _linked_libpython_windows Backport find_libpython.py changes from PyCall Sep 23, 2018
@tkf tkf added this to the 0.2 milestone Sep 28, 2018
@tkf tkf force-pushed the linked_libpython_windows branch from c8e4865 to 5fa612d Compare October 24, 2018 01:19
@tkf tkf merged commit 3bdcc7e into JuliaPy:master Oct 24, 2018
@tkf tkf deleted the linked_libpython_windows branch October 24, 2018 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants