Only set PYTHONHOME when using conda#411
Only set PYTHONHOME when using conda#411yuvipanda wants to merge 1 commit intoJuliaPy:masterfrom yuvipanda:virtualenv-fixes
Conversation
|
This is my first Julia piece of code (although @tkelman helped a lot!). |
| const pyversion_build = $(repr(pyversion)) | ||
| const PYTHONHOME = "$(escape_string(PYTHONHOME))" | ||
| const wPYTHONHOME = $(wstringconst(PYTHONHOME)) | ||
| const PYTHONHOME = $(PYTHONHOME == nothing ? nothing : "\"" * escape_string(PYTHONHOME) * "\"") |
There was a problem hiding this comment.
Not sure if this is the best way to do this
|
I've also not actually tested this on Conda! |
| is_windows() ? exec_prefix : pysys(python, "prefix") * ":" * exec_prefix | ||
| else | ||
| ENV["PYTHONHOME"] | ||
| get(ENV, "PYTHONHOME", nothing) |
There was a problem hiding this comment.
Looking at what Py_SetPythonHome does after we first got this going, maybe it would be easier to do get(ENV, "PYTHONHOME", "") and possibly not need the rest of the patch after this point. Dunno whether a user having the env var PYTHONHOME set to an empty string is sane and should be honored.
|
This patch doesn't seem right to me. It seems like we should always call It sounds like we might be just setting PYTHONHOME incorrectly in some cases, and the solution is to figure out how to set it correctly? |
In case of |
|
I think #578 supersedes this. |
4 participants
Fixes #410