Repository navigation
feat: support MySQL ALTER DATABASE options - #2700
Merged
manticore-projects merged 1 commit intoSep 25, 2026
Merged
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
manticore-projects
pushed a commit
that referenced
this pull request
Oct 17, 2026
…#2811) Since #2700, every PostgreSQL ALTER DATABASE fails to parse, while 5.4 returned an UnsupportedStatement. Model RENAME TO, OWNER TO, SET TABLESPACE, REFRESH COLLATION VERSION, the [WITH] options and SET/RESET of configuration parameters. Outside the MySQL dialect, other ALTER DATABASE forms are unsupported statements again, and ALTER SCHEMA with MySQL options no longer requires that dialect. Extract the SET/RESET state of AlterRole into ConfigurationParameterChange, which ALTER DATABASE shares; AlterRole keeps its accessors. Type each PostgreSQL CREATE DATABASE option, accept the CHAR SET and CHARSET spellings, keep CreateDatabase options in one list and drop the empty raw option that added a trailing space. Signed-off-by: minleejae <mmj9808@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL ALTER DATABASE options currently fall through to UnsupportedStatement, preventing callers from inspecting or changing database defaults through the AST.
Add a structured AlterDatabase statement and reuse the existing CREATE DATABASE / CREATE SCHEMA option model and parser for character set, collation and encryption. READ ONLY is parsed only in ALTER. Preserve optional database names, equals signs and the MySQL SCHEMA synonym, with visitor and deparser integration.
Validation: full Gradle check and grammar ambiguity gate; option mutation, visitor dispatch, unnamed database, statement boundaries and invalid READ ONLY values. The three audited option groups execute and retain their SHOW CREATE DATABASE results on both MySQL 9.7.2 and 26.7.0.