Separate JSON operators with spaces so #> deparses correctly - #2487
Merged
manticore-projects merged 1 commit intoAug 19, 2026
Conversation
JsonExpression.toString glued each operator directly onto its operand, so a #> ... deparsed as a#>... . Because # is a legal identifier character, that re-parses as a# > ... -- a GreaterThan, a different tree from the original JsonExpression. Emit a space on each side of the operator, matching the JsonOperator visitor.
Contributor
|
Thank you much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonExpression.toString()appends each operator directly onto its operand, soa #> '{b}'deparses toa#>'{b}'. Because#is a legal identifier character,that output re-parses as
a#>'{b}'-- a GreaterThan comparison rather thanthe original JSON expression, so deparse+reparse is not round-trip safe.
Emit a space on each side of the operator, matching how the JsonOperator is printed
elsewhere. Added a test that parses
#>and#>>, deparses, and checks the resultstill parses back to a JsonExpression.