Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser misplaces the LIMIT clause when parsing a UNION query that doesn't include brackets.
The original query:
select col from tbl union distinct select col2 from tbl order by test limit 100;The query after parsing (before the fix):
SELECT tbl.col FROM tbl UNION DISTINCT SELECT tbl.col2 FROM tbl LIMIT 100 ORDER BY testNote that the LIMIT clause shows up before the ORDER BY clause, which is invalid.
After the fix, the query parses as the same as the original query.
Fixes #1018
Fixes #1116