test(signals): cover isTestFile and isCodeFile path classifiers - #947
Conversation
🔍 Maintainer reviewReviewed 1 file(s) — ✅ all CI green. Suggested action: ✅ Safe to merge — both reviewers found no blocking issues. Reviewer A · No blocking issues spotted. Reviewer B · No blocking issues spotted. |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 110 110
Lines 15006 15006
Branches 5423 5423
=======================================
Hits 14500 14500
Misses 104 104
Partials 402 402 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ghost
left a comment
There was a problem hiding this comment.
Both reviewers approved, all CI is green, and this is a small, low-risk change — auto-merging.
Summary
Adds unit coverage for
isTestFileandisCodeFileinsrc/signals/local-branch.ts— pure path classifiers that decide whether a changed file is a test or a production source file.Why
These helpers feed file-level signal logic but had no direct tests; the existing
local-branch.test.tsexercises onlybuildLocalBranchAnalysis/findCurrentBranchPullRequest. The new table covers everyisTestFilebranch (test/spec directories,src/test,_test.{go,py,rb},_spec.rb, dotted.test/.spec) plus near-miss negatives (testing/,contest/,helper_test.ts,config_spec.py), andisCodeFile's full extension set together with its test-file exclusion.Validation
No product behavior changes; tests only.