Skip to content

fix(engine): remove the dead AMS_POLICY_SPEC_FILENAMES discovery constant #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shin-core wants to merge 1 commit into from
Closed

fix(engine): remove the dead AMS_POLICY_SPEC_FILENAMES discovery constant #9004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/loopover-engine/src/ams-policy-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,3 @@ export function parseAmsPolicySpecContent(content: string | null | undefined): P
}
return parseAmsPolicySpec(parsed);
}

/** The documented `.loopover-ams` file-discovery order (first match wins), mirroring `MINER_GOAL_SPEC_FILENAMES`. */
export const AMS_POLICY_SPEC_FILENAMES = [".loopover-ams.yml", ".github/loopover-ams.yml", ".loopover-ams.json", ".github/loopover-ams.json"] as const;
1 change: 0 additions & 1 deletion packages/loopover-engine/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,6 @@ export {
DEFAULT_AMS_POLICY_SPEC,
parseAmsPolicySpec,
parseAmsPolicySpecContent,
AMS_POLICY_SPEC_FILENAMES,
AMS_NETWORK_ALLOWLIST_ECOSYSTEMS,
type AmsCapLimits,
type AmsNetworkAllowlist,
Expand Down
7 changes: 0 additions & 7 deletions packages/loopover-engine/test/ams-policy-spec-parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { test } from "node:test";
import assert from "node:assert/strict";
import {
AMS_POLICY_SPEC_FILENAMES,
DEFAULT_AMS_POLICY_SPEC,
parseAmsPolicySpec,
parseAmsPolicySpecContent,
Expand All @@ -10,12 +9,6 @@ import {
test("barrel: the public entrypoint re-exports the AmsPolicySpec parser API", () => {
assert.equal(typeof parseAmsPolicySpec, "function");
assert.equal(typeof parseAmsPolicySpecContent, "function");
assert.deepEqual(AMS_POLICY_SPEC_FILENAMES, [
".loopover-ams.yml",
".github/loopover-ams.yml",
".loopover-ams.json",
".github/loopover-ams.json",
]);
});

test("parseAmsPolicySpec: missing raw input returns an absent safe-default spec with no warnings", () => {
Expand Down
7 changes: 0 additions & 7 deletions test/unit/ams-policy-spec-parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { describe, expect, it } from "vitest";
import {
AMS_POLICY_SPEC_FILENAMES,
DEFAULT_AMS_POLICY_SPEC,
parseAmsPolicySpec,
parseAmsPolicySpecContent,
Expand All @@ -10,12 +9,6 @@ describe("AmsPolicySpec parser (#5132)", () => {
it("re-exports the parser API from the engine barrel", () => {
expect(typeof parseAmsPolicySpec).toBe("function");
expect(typeof parseAmsPolicySpecContent).toBe("function");
expect(AMS_POLICY_SPEC_FILENAMES).toEqual([
".loopover-ams.yml",
".github/loopover-ams.yml",
".loopover-ams.json",
".github/loopover-ams.json",
]);
});

it("treats missing raw input as an absent safe-default spec", () => {
Expand Down
Loading