fix(db): add eight latest-only signal_snapshots types to retention dedupe - #8935
Conversation
…dupe These writers INSERT a fresh row every run while consumers only read the latest; include them in LATEST_ONLY_SIGNAL_SNAPSHOT_TYPES so dedupe collapses stale rows per repo. Closes JSONbored#8900
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8935 +/- ##
==========================================
+ Coverage 90.56% 90.58% +0.02%
==========================================
Files 96 97 +1
Lines 22490 22547 +57
Branches 3884 3904 +20
==========================================
+ Hits 20367 20424 +57
Misses 1945 1945
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-26 13:59:16 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
LATEST_ONLY_SIGNAL_SNAPSHOT_TYPES:config-quality,label-audit,maintainer-lane,maintainer-cut-readiness,contributor-intake-health,issue-quality,repo-outcome-patterns,pr-reviewability.dedupeSignalSnapshotsharness so each of the eight types collapses N stale rows to 1 per repo (other repos preserved).Closes #8900
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
LATEST_ONLY_SIGNAL_SNAPSHOT_TYPESlist plus a dedicateddedupeSignalSnapshotsunit test covering all 8 types; CI is source of truth.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI changes.
Notes
queue-healthremains excluded as a real historical series.