ams: reconcile README/DEPLOYMENT local-storage inventory -- two real SQLite stores are undocumented - #8923
Conversation
…SQLite stores are undocumented Fixes JSONbored#8850
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-26 13:37:39 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionPartially addressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
Reconciles the loopover-miner local SQLite storage inventory across operator docs so README and DEPLOYMENT match the stores
migrate-cli.tsandstatusdoctor actually manage.Fixes #8850
Problem
Two real, actively-used SQLite stores were missing from operator-facing documentation:
contribution-profile-cache.sqlite3contribution-profile-cache.jsLOOPOVER_MINER_CONTRIBUTION_PROFILE_CACHE_DBranked-candidates.sqlite3ranked-candidates.jsLOOPOVER_MINER_RANKED_CANDIDATES_DBBoth are wired into migration and doctor sweeps, but were absent from:
packages/loopover-miner/README.md— Local storage tablepackages/loopover-miner/DEPLOYMENT.md— on-disk file listingtest/unit/miner-local-store-readme.test.ts— hardcoded regression guardChanges
Documentation inventory
LOOPOVER_MINER_CONFIG_DIRSQLite listing with issue cross-refs (AMS contribution-profile: local cache store + doctor integration #6797, Replace the manual copy/paste workflow with a live fetch #4859).Operator-doc polish (same PR)
doctorvolume-mount example path (token-fileplaceholder).Regression test
miner-local-store-readme.test.tsso CI fails if either store is removed from README again.Deliverables (issue #8850)
miner-local-store-readme.test.tsincludes both filenames and passesTest plan
test/unit/miner-local-store-readme.test.ts— enforces README ↔ code parity for all local storesExpected outcome
Operators reading README or DEPLOYMENT see a complete, accurate list of every local SQLite store the miner creates — matching what migration and doctor actually manage.