fix(orb): emit allowedRoles on explain/generate-tests denial usage and record configuration command usage - #8705
Conversation
…d record configuration command usage The `explain` and `generate-tests` denial handlers recorded their `recordGithubProductUsage` events without `allowedRoles`, even though the paired `recordAuditEvent` calls (and every sibling command — gate-override, resolve, pause, resume) include it. Add `allowedRoles` to the product-usage metadata for both the mention and PR-panel generate-tests denial paths so the telemetry matches the audit trail. `maybeProcessConfigurationCommand`/`recordConfigurationSkip` never emitted any product-usage event, leaving `@loopover configuration` invocations invisible in usage reporting. Record `configuration_posted` on a successful post and `configuration_skipped` on a skip/denial, mirroring how every other command handler records usage. Instrumentation only — no functional or authorization behavior changes. Closes JSONbored#8688
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8705 +/- ##
==========================================
+ Coverage 90.56% 91.19% +0.63%
==========================================
Files 96 97 +1
Lines 22490 25672 +3182
Branches 3884 5014 +1130
==========================================
+ Hits 20367 23411 +3044
- Misses 1945 1993 +48
- Partials 178 268 +90
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-26 00:01:57 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
fix(orb): emit allowedRoles on explain/generate-tests denial usage and record configuration command usage
The
explainandgenerate-testsdenial handlers recorded theirrecordGithubProductUsageevents withoutallowedRoles, even though thepaired
recordAuditEventcalls (and every sibling command — gate-override,resolve, pause, resume) include it. Add
allowedRolesto the product-usagemetadata for both the mention and PR-panel generate-tests denial paths so the
telemetry matches the audit trail.
maybeProcessConfigurationCommand/recordConfigurationSkipnever emitted anyproduct-usage event, leaving
@loopover configurationinvocations invisible inusage reporting. Record
configuration_postedon a successful post andconfiguration_skippedon a skip/denial, mirroring how every other commandhandler records usage.
Instrumentation only — no functional or authorization behavior changes.
Closes #8688