feat(review): capture fired signals + reversal mapping for the slop and quality gate scores

[RealDiligent]

Summary

• Closes calibration: capture writers + corpus mappings for the slop and quality gate scores #8223
• slopGateMinScore and qualityGateMinScore gate real verdicts today but recorded no signal.rule_fired events, so no corpus could ever form for them and the knob registry could never govern their thresholds.
• Mirrors calibration: wire linked_issue_scope_mismatch into the shared signal-tracking module (fired + reversal) #8101/calibration: wire recordRuleFired/recordHumanOverride for the remaining isConfiguredGateBlocker codes (excludes linked_issue_scope_mismatch, covered by #8101) #8104's capture wiring exactly: recordGateScoreSignals(env, policy, repoFullName, prNumber) fires one rule per knob (slop_gate_score, quality_gate_score) at the env-bearing gate path — wired beside recordConfiguredGateBlockerSignals's existing call — with the same filter each pure evaluation applies, including the same policy transform: the function applies applyMergeReadinessGate(policy) first (exactly as evaluateGateCheckCore does before buildSlopGateBlocker ever sees the policy), so a repo gating slop via the feat(github-app): merge-readiness aggregate gate #551 composite promotion with slopGateMode unset is captured too — this was the defect that closed the previous attempt at this issue (feat(review): capture fired signals + reversal mapping for the slop and quality gate scores #8235), resolved here with a dedicated composite-promotion regression test. Slop evaluates only in (effective) block mode with a non-null risk, including the default-60 threshold; quality evaluates whenever its mode is not off with both a score and threshold present, pass AND fail alike — a threshold backtest needs both outcomes. targetKey = repo#pr.
• Metadata carries the score normalized to [0, 1] (both scores are 0-100 integers per normalizeScore, divided by 100 to be confidence-equivalent for buildConfidenceThresholdClassifier replays — documented beside the writer) plus the detection's own detail string as rawSignal — never diff content, per calibration: capture bounded raw context for the remaining isConfiguredGateBlocker codes, excluding secret_leak #8130's raw-context posture for computed-score rules. Best-effort writes that can never affect the verdict.
• Reversal labeling: both ids join CONFIGURED_GATE_BLOCKER_SIGNAL_CODES via the exported GATE_SCORE_SIGNAL_CODES constant, with the justification the issue requires recorded beside it: slop carries direct gate authority in block mode (composite-promoted or direct); quality is advisory-only but registry-governable, and a reversal labels the overall bot outcome its score contributed to — exactly the corpus label the drift/loosening evaluators consume. The fired side is unaffected (that list feeds only the reversal lookups).

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run typecheck
• npm run actionlint
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Ran the writer's full suite (vitest run test/unit/configured-gate-blocker-signals.test.ts — 21 tests green, including the 7 calibration: capture writers + corpus mappings for the slop and quality gate scores #8223 cases: both firing arms per knob with crossing and non-crossing outcomes plus the default slop threshold; the merge-readiness composite promotion case (the prior attempt's defect, now regression-pinned); every never-evaluated arm; the normalization bounds; the no-diff-content invariant; and the rejecting-SignalStore fail-open path covering both write arms) plus the full root npm run typecheck. Per-diff-line lcov intersection verified 100% line+branch on advisory.ts's changed region. actionlint/workers/mcp/ui checks are untouched surfaces; CI runs them all.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — backend capture wiring only (no UI, docs, or extension surface touched; no registry entries, no knob movement, per the issue's Boundaries).

Notes

• Supersedes feat(review): capture fired signals + reversal mapping for the slop and quality gate scores #8235 (closed by the review agent for the effective-policy defect described above). The fix reads every field from applyMergeReadinessGate(policy)'s output — the same promoted policy evaluateGateCheckCore hands its pure evaluations — and the new #551 parity test locks the composite-promoted case in.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (8017db1) to head (2f2353e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8239      +/-   ##
==========================================
- Coverage   92.11%   90.39%   -1.72%     
==========================================
  Files         779       99     -680     
  Lines       78430    26104   -52326     
  Branches    23696     5127   -18569     
==========================================
- Hits        72245    23598   -48647     
+ Misses       5062     2233    -2829     
+ Partials     1123      273     -850     

Flag	Coverage Δ
shard-1	79.09% <68.18%> (+23.33%)	⬆️
shard-2	35.35% <59.09%> (-14.46%)	⬇️
shard-3	41.03% <100.00%> (-15.45%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/queue/processors.ts	95.73% <100.00%> (+<0.01%)	⬆️
src/rules/advisory.ts	98.10% <100.00%> (+0.13%)	⬆️

... and 680 files with indirect coverage changes

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-23 14:12:28 UTC}

3 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
The AI review returned non-blocking notes for this change but did not include a separate narrative summary. Review the nits below before deciding this PR.

Nits — 4 non-blocking

• src/rules/advisory.ts: the new `GATE_SCORE_SIGNAL_CODES` block carries a very long comment (roughly 10 lines) — consider trimming to the load-bearing justification only, per the file's own stated convention of keeping comments tight.
• test/unit/configured-gate-blocker-signals.test.ts:2 reformats the import statement inline with `recordGateScoreSignals` on the same line as the opening brace, which is a stylistic inconsistency with the rest of the multi-line import block.
• src/rules/advisory.ts: `DEFAULT_SLOP_BLOCK_THRESHOLD` is reused here as it was in `buildSlopGateBlocker`, but there's no shared single source of truth check enforced other than by convention — consider a comment cross-reference if drift risk matters here (arguably already covered by the existing 'mirrors' doc comment).
• The PR description mentions this closes calibration: capture writers + corpus mappings for the slop and quality gate scores #8223 and fixes the defect that sank feat(review): capture fired signals + reversal mapping for the slop and quality gate scores #8235 (composite-promotion case) — the added regression test for that case is exactly what's needed and is a nice, targeted addition.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8223
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 343 registered-repo PR(s), 136 merged, 36 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	RealDiligent; Gittensor profile; 343 PR(s), 36 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The PR adds recordGateScoreSignals firing slop_gate_score and quality_gate_score with the required filter (mirroring pure evaluation incl. merge-readiness composite promotion), normalized [0,1] confidence with documented normalization, detection detail as rawSignal (never diff), best-effort writes, and wires both codes into the existing CONFIGURED_GATE_BLOCKER_SIGNAL_CODES reversal list with justi

Review context

• Author: RealDiligent
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, Ruby, JavaScript, Svelte, TypeScript, Markdown, MDX, Rust
• Official Gittensor activity: 343 PR(s), 36 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.