Skip to content

chore(miner): migrate batch 4.6 foundational lib modules to TypeScript (#7314) - #7321

Closed
andriypolanski wants to merge 1 commit into
JSONbored:mainfrom
andriypolanski:chore/miner-ts-batch-4.6-7314
Closed

chore(miner): migrate batch 4.6 foundational lib modules to TypeScript (#7314)#7321
andriypolanski wants to merge 1 commit into
JSONbored:mainfrom
andriypolanski:chore/miner-ts-batch-4.6-7314

Conversation

@andriypolanski

Copy link
Copy Markdown
Contributor

Summary

Closes #7314

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • No behavior change; existing miner unit tests for these eight modules continue to pass unmodified (243 related tests across the listed suites). Codecov patch applies only to src/** — this PR only touches packages/loopover-miner/lib/**. Ran npm run build:miner, npm run test:miner-pack, git diff --check, and npm run actionlint. Full test:ci / UI / workers / coverage chain was exercised on the sibling batch 4.7 PR (chore(miner): migrate batch 4.7 foundational lib modules to TypeScript (#7315) #7319) against the same pipeline; this migration is the same class of change.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — no visible UI/frontend/docs change.

Notes

Made with Cursor

JSONbored#7314)

Convert eight foundational loopover-miner lib modules from plain .js +
hand-maintained .d.ts to real TypeScript under the existing in-place
tsc emit pipeline, with zero behavior change.

Co-authored-by: Cursor <cursoragent@cursor.com>
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@andriypolanski
andriypolanski marked this pull request as draft July 19, 2026 16:30
@JSONbored JSONbored closed this Jul 19, 2026
@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(miner): migrate foundational, most-depended-on packages/loopover-miner/lib modules to TypeScript (batch 4.6 of 8 (Phase 4))

3 participants