chore(miner): migrate batch 4.6 foundational lib modules to TypeScript (#7314) - #7321
Closed
andriypolanski wants to merge 1 commit into
Closed
chore(miner): migrate batch 4.6 foundational lib modules to TypeScript (#7314)#7321andriypolanski wants to merge 1 commit into
andriypolanski wants to merge 1 commit into
Conversation
JSONbored#7314) Convert eight foundational loopover-miner lib modules from plain .js + hand-maintained .d.ts to real TypeScript under the existing in-place tsc emit pipeline, with zero behavior change. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
andriypolanski
marked this pull request as draft
July 19, 2026 16:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policy-verdict-cache,submission-freshness-check,github-token-resolution,worktree-allocator,contribution-profile,http-retry,repo-clone, andchat-action-registryfrom plain.js+ hand-maintained.d.tsto real.tsunder the existing in-placetscemit pipeline from chore(miner): add a real tsc build pipeline for loopover-miner (#7290) #7299..js/.d.tsviatscso published layout and consumer import paths stay unchanged; zero behavior change.Closes #7314
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
src/**— this PR only touchespackages/loopover-miner/lib/**. Rannpm run build:miner,npm run test:miner-pack,git diff --check, andnpm run actionlint. Fulltest:ci/ UI / workers / coverage chain was exercised on the sibling batch 4.7 PR (chore(miner): migrate batch 4.7 foundational lib modules to TypeScript (#7315) #7319) against the same pipeline; this migration is the same class of change.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI/frontend/docs change.
Notes
lib/foo.ts→lib/foo.js+ regenerated.d.ts).tsconfig.jsonchanges; the existinglib/**/*.tsinclude glob picks up the new sources.Made with Cursor