Skip to content

fix(github): reject per-segment whitespace in splitRepo #6664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 16, 2026
Merged

fix(github): reject per-segment whitespace in splitRepo #6664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/github/pr-actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ const COMMIT_MESSAGES_PAGE_SIZE = 100;
// recorded, not swallowed.

function splitRepo(repoFullName: string): { owner: string; repo: string } {
if (repoFullName !== repoFullName.trim()) {
throw new Error(`Invalid repository full name: ${repoFullName}`);
}
// Reject any whitespace (leading, trailing, or per-segment like `owner/ repo`) so a padded slug can never
// reach a GitHub call — a valid owner/repo name never contains spaces. Mirrors parseRepoFullName in
// assignees.ts / labels.ts (#6613).
const parts = repoFullName.split("/");
if (parts.length !== 2 || !parts[0] || !parts[1]) {
if (parts.length !== 2 || !parts[0] || !parts[1] || /\s/.test(repoFullName)) {
throw new Error(`Invalid repository full name: ${repoFullName}`);
}
return { owner: parts[0], repo: parts[1] };
Expand Down
11 changes: 11 additions & 0 deletions test/unit/github-pr-actions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ describe("GitHub PR action primitives (#778)", () => {
await expect(closePullRequest(createTestEnv(), 1, " owner/repo ", 4)).rejects.toThrow(
/Invalid repository full name/,
);
// Per-segment padding (#6613) — mirrors assignees.ts parseRepoFullName coverage.
for (const padded of ["owner/ repo", "owner /repo"]) {
await expect(closePullRequest(createTestEnv(), 1, padded, 4)).rejects.toThrow(
/Invalid repository full name/,
);
}
let called = false;
vi.stubGlobal("fetch", async () => {
called = true;
Expand All @@ -32,6 +38,11 @@ describe("GitHub PR action primitives (#778)", () => {
await expect(closePullRequest(envWithKey(), 1, " owner/repo ", 4)).rejects.toThrow(
/Invalid repository full name/,
);
for (const padded of ["owner/ repo", "owner /repo"]) {
await expect(closePullRequest(envWithKey(), 1, padded, 4)).rejects.toThrow(
/Invalid repository full name/,
);
}
expect(called).toBe(false);
});

Expand Down