Skip to content

fix(engine): stop the collision report using unscoped issue.linkedPrs for risk escalation #6470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 16, 2026
Merged

fix(engine): stop the collision report using unscoped issue.linkedPrs for risk escalation #6470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/loopover-engine/src/signals/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ export function buildCollisionReport(
const items = [issueItem(issue), ...linkedPrs.map(prItem)];
clusters.set(`issue-${issue.number}`, {
id: `issue-${issue.number}`,
risk: linkedPrs.length > 1 || issue.linkedPrs.length > 1 ? "high" : "medium",
risk: linkedPrs.length > 1 ? "high" : "medium",
reason: `Open PR work references issue #${issue.number}.`,
items,
});
Expand Down
30 changes: 30 additions & 0 deletions test/unit/signals.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,36 @@ describe("world-class backend signals", () => {
expect(report.clusters[0]?.items.map((item) => item.number)).toContain(7);
});

it("does not escalate a single-real-PR issue cluster to high risk from unscoped issue.linkedPrs text mentions (regression)", () => {
// Issue #40 has exactly ONE real open PR (#12) that closes it via `linkedIssues`, but the issue's own
// cached `linkedPrs` (parsed from contributor-controlled issue body text, e.g. "see PR #8 and PR #9 for
// earlier discussion") mentions two PR numbers that are not actually competing work. The cluster's risk
// must be driven only by the genuinely-scoped `linkedPrs` (real open PRs), not this raw text-mention field.
const soloIssue: IssueRecord = {
repoFullName: repo.fullName,
number: 40,
title: "Solo-linked issue with unrelated body mentions",
state: "open",
authorLogin: "reporter",
labels: ["bug"],
linkedPrs: [8, 9],
};
const solePr: PullRequestRecord = {
repoFullName: repo.fullName,
number: 12,
title: "Fix solo-linked issue",
state: "open",
authorLogin: "oktofeesh1",
authorAssociation: "NONE",
labels: ["bug"],
linkedIssues: [40],
updatedAt: "2026-04-01T00:00:00.000Z",
};
const report = buildCollisionReport(repo.fullName, [soloIssue], [solePr]);
const cluster = report.clusters.find((entry) => entry.id === "issue-40");
expect(cluster?.risk).toBe("medium");
});

it("builds maintainer burden from queue hygiene signals", () => {
const collisions = buildCollisionReport(repo.fullName, issues, pullRequests);
const health = buildQueueHealth(repo, issues, pullRequests, collisions);
Expand Down