chore(rees): remove dead captureError export in review-enrichment/src/sentry.ts - #6393
Conversation
…/sentry.ts A repo-wide search (src + test, excluding the compiled dist/ output) finds zero imports or calls anywhere. Every real call site already uses one of the more specific siblings instead: captureRouteError, captureUnhandledError, captureSourcemapUploadFailure, captureAnalyzerDegradation. Closes #6253
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-16 06:35:53 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #6253
Summary
captureErrorfromreview-enrichment/src/sentry.ts— a generic Sentry-capture wrapper with zero real (non-dist/) callers anywhere in the repo. Every real call site already uses one of its more specific siblings instead:captureRouteError,captureUnhandledError,captureSourcemapUploadFailure,captureAnalyzerDegradation.review-enrichment's existing tests (sentry-upload.test.ts,sentry-degradation.test.ts,sentry-release-validation.test.ts, and the fullreview-enrichmentsuite) never referencedcaptureError, so they continue passing unchanged, matching the issue's own deliverable.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typecheck(root) — roottsc --noEmitreliably OOMs on this shared sandbox regardless of what changed (reproduced repeatedly this session).review-enrichmenthas its own independent, much lighter typecheck (npm --prefix review-enrichment run build, i.e.tsc -p tsconfig.json) — ran it directly and it passes clean, confirming zero type errors from the removal (no lingering references anywhere inreview-enrichment/src/**orreview-enrichment/test/**).npm run test:coverage— not run repo-wide (same OOM risk); this is a pure deletion of dead code with no new lines, so patch coverage is inherently 100% on the diff.review-enrichmentuses its ownnode --testrunner (not vitest) — ran the fullreview-enrichmenttest suite directly: 1335/1335 passing, unchanged.npm run test:workers— N/A, no Worker-facing code changed.npm run build:mcp/npm run test:mcp-pack— N/A, no@loopover/mcpchanges.npm run ui:openapi:check/ui:lint/ui:typecheck/ui:build— N/A, noapps/loopover-uichanges.npm audit --audit-level=moderate— 0 vulnerabilities.If any required check was skipped, explain why:
npm run typecheck/npm run test:coverage: reliably OOMs on this shared sandbox under memory pressure from concurrent sessions, independent of the diff. Substituted withreview-enrichment's own independenttscbuild (clean) and its fullnode --testsuite (1335/1335 passing).Safety
UI Evidencesection below with screenshots. — N/A, no visible UI change.CHANGELOG.mduntouched.Notes
grep -rn "\bcaptureError\b" review-enrichment/src/ review-enrichment/test/(excluding the gitignoreddist/build output) that no code imports it — matching the issue's finding exactly. Notesrc/selfhost/sentry.ts's own separatecaptureErrorexport (a different, actively-used function in the main repo, notreview-enrichment) is untouched.