Skip to content

chore(rees): remove dead captureError export in review-enrichment/src/sentry.ts - #6393

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
galuis116:chore/remove-dead-rees-capture-error
Jul 16, 2026
Merged

chore(rees): remove dead captureError export in review-enrichment/src/sentry.ts#6393
JSONbored merged 1 commit into
JSONbored:mainfrom
galuis116:chore/remove-dead-rees-capture-error

Conversation

@galuis116

Copy link
Copy Markdown
Contributor

Closes #6253

Summary

  • Remove captureError from review-enrichment/src/sentry.ts — a generic Sentry-capture wrapper with zero real (non-dist/) callers anywhere in the repo. Every real call site already uses one of its more specific siblings instead: captureRouteError, captureUnhandledError, captureSourcemapUploadFailure, captureAnalyzerDegradation.
  • No test changes needed: review-enrichment's existing tests (sentry-upload.test.ts, sentry-degradation.test.ts, sentry-release-validation.test.ts, and the full review-enrichment suite) never referenced captureError, so they continue passing unchanged, matching the issue's own deliverable.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves — Closes chore(rees): remove dead captureError export in src/sentry.ts #6253.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck (root) — root tsc --noEmit reliably OOMs on this shared sandbox regardless of what changed (reproduced repeatedly this session). review-enrichment has its own independent, much lighter typecheck (npm --prefix review-enrichment run build, i.e. tsc -p tsconfig.json) — ran it directly and it passes clean, confirming zero type errors from the removal (no lingering references anywhere in review-enrichment/src/** or review-enrichment/test/**).
  • npm run test:coverage — not run repo-wide (same OOM risk); this is a pure deletion of dead code with no new lines, so patch coverage is inherently 100% on the diff. review-enrichment uses its own node --test runner (not vitest) — ran the full review-enrichment test suite directly: 1335/1335 passing, unchanged.
  • npm run test:workers — N/A, no Worker-facing code changed.
  • npm run build:mcp / npm run test:mcp-pack — N/A, no @loopover/mcp changes.
  • npm run ui:openapi:check / ui:lint / ui:typecheck / ui:build — N/A, no apps/loopover-ui changes.
  • npm audit --audit-level=moderate — 0 vulnerabilities.
  • New/changed behavior has tests — N/A, this removes dead code only; no behavior changed, confirmed by the full unchanged 1335-test suite still passing.

If any required check was skipped, explain why:

  • Root npm run typecheck / npm run test:coverage: reliably OOMs on this shared sandbox under memory pressure from concurrent sessions, independent of the diff. Substituted with review-enrichment's own independent tsc build (clean) and its full node --test suite (1335/1335 passing).

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. — N/A.
  • API/OpenAPI/MCP behavior is updated and tested where needed. — N/A.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. — N/A, no UI changes.
  • Visible UI changes include a UI Evidence section below with screenshots. — N/A, no visible UI change.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs. — CHANGELOG.md untouched.

Notes

  • Confirmed via grep -rn "\bcaptureError\b" review-enrichment/src/ review-enrichment/test/ (excluding the gitignored dist/ build output) that no code imports it — matching the issue's finding exactly. Note src/selfhost/sentry.ts's own separate captureError export (a different, actively-used function in the main repo, not review-enrichment) is untouched.

…/sentry.ts

A repo-wide search (src + test, excluding the compiled dist/ output)
finds zero imports or calls anywhere. Every real call site already
uses one of the more specific siblings instead: captureRouteError,
captureUnhandledError, captureSourcemapUploadFailure,
captureAnalyzerDegradation.

Closes #6253
@galuis116
galuis116 requested a review from JSONbored as a code owner July 16, 2026 06:05
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-16 06:35:53 UTC

1 file · 1 AI reviewer · no blockers · readiness 77/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a clean, well-scoped deletion of a dead `captureError` export from `review-enrichment/src/sentry.ts` that has no real callers, closing issue #6253. The removal is a pure subtraction (no new lines), all four sibling capture functions remain intact and unaffected, and the file's structure and exports otherwise stay unchanged. No test changes are needed since existing tests never referenced the removed function.

Nits — 3 non-blocking
  • The PR body claims 'zero real (non-dist/) callers anywhere in the repo' but the diff itself doesn't show that verification — worth double-checking no external package (outside review-enrichment) imports this from a built/dist output.
  • Consider a quick repo-wide grep for `captureError` (not just `review-enrichment/src`) before merging, in case it's re-exported or imported elsewhere under a barrel file.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6253
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 1926 registered-repo PR(s), 1268 merged, 54 issue(s).
Contributor context ✅ Confirmed Gittensor contributor galuis116; Gittensor profile; 1926 PR(s), 54 issue(s).
Improvement ℹ️ None detected risk: low · value: none
Review context
  • Author: galuis116
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 1926 PR(s), 54 issue(s).
  • Related work: Titles/paths share 7 meaningful terms. (issue #6253, issue #6172)
  • Related work: Titles/paths share 7 meaningful terms. (issue #6253, issue #6182)
  • Related work: Titles/paths share 7 meaningful terms. (issue #6253, issue #6187)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 3 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 16, 2026
@JSONbored
JSONbored merged commit e05685b into JSONbored:main Jul 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(rees): remove dead captureError export in src/sentry.ts

2 participants