Skip to content

chore(selfhost): remove dead nonConsumingRetryDelayMs export #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 16, 2026
Merged

chore(selfhost): remove dead nonConsumingRetryDelayMs export #6357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/selfhost/queue-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,10 +689,6 @@ export function githubRateLimitRetryDelayMs(
return null;
}

export function nonConsumingRetryDelayMs(error: unknown): number | null {
return githubRateLimitRetryDelayMs(error);
}

export function consumingRetryDelayMs(
error: unknown,
defaultDelayMs: number,
Expand Down
20 changes: 0 additions & 20 deletions test/unit/selfhost-queue-common.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import {
jobClaimSortKey,
jobPriority,
matchesGitHubRateLimitAdmissionTarget,
nonConsumingRetryDelayMs,
parsePositiveIntEnv,
queueBackgroundConcurrency,
queueDeadLetterAutoRetryMaxExtraAttempts,
Expand Down Expand Up @@ -1481,25 +1480,6 @@ describe("self-host queue common helpers", () => {
).toBeNull();
});

it("keeps only GitHub rate limits on the non-consuming retry path", () => {
expect(nonConsumingRetryDelayMs(new Error("boom"))).toBeNull();
expect(
nonConsumingRetryDelayMs({
status: 429,
response: { headers: new Headers({ "retry-after": "2" }) },
}),
).toBe(2_000);
expect(
nonConsumingRetryDelayMs(
new RetryableJobError("AI review pending", {
retryAfterMs: 1234,
retryKind: "ai_review_public_summary_missing",
}),
),
).toBeNull();
expect(nonConsumingRetryDelayMs(new Error("openai rate limit"))).toBeNull();
});

it("uses RetryableJobError delays on the bounded consuming retry path", () => {
expect(consumingRetryDelayMs(new Error("boom"), 77)).toBe(77);
expect(
Expand Down
Loading