feat(review): add a visible caption under each Visual/Scroll preview thumbnail - #6341
Conversation
…thumbnail Advances #6324 The screenshot-table contract this bot enforces on contributors (see e.g. .claude/skills/metagraphed/SKILL.md's Phase B2 in JSONbored/metagraphed) requires "each image is a clickable thumbnail... with a one-line caption underneath". The bot's own Visual preview / Scroll preview tables never rendered one -- the route/viewport/theme label existed only as an invisible alt attribute. Adds a <br><sub>label</sub> line (the same label already used for alt) after each thumbnail, inside the same table cell (a literal newline would break the GFM table row). Purely additive to both buildBeforeAfterCollapsible and buildScrollPreviewCollapsible's cell() builders -- every existing assertion about the <a>/<img> markup still matches unchanged. This is one of two fixes for #6324; the image-downscaling half (the "before images are massive" file-size complaint) is a separate, larger change and will land in its own follow-up PR.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-16 02:57:46 UTC
Review summary Nits — 5 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionPartially addressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6341 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 597 597
Lines 47170 47170
Branches 15016 15016
=======================================
Hits 45098 45098
Misses 1290 1290
Partials 782 782
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Summary
.claude/skills/metagraphed/SKILL.md's Phase B2 in JSONbored/metagraphed) requires "each image is a clickable thumbnail... with a one-line caption underneath." The bot's own Visual preview / Scroll preview tables never rendered one — the route/viewport/theme label existed only as an invisiblealtattribute.<br><sub>label</sub>line (the same label already used foralt) after each thumbnail, inside the same table cell (a literal newline would break the GFM table row). Purely additive to bothbuildBeforeAfterCollapsibleandbuildScrollPreviewCollapsible'scell()builders — every existing assertion about the<a>/<img>markup still matches unchanged.This is one of two fixes for #6324; the image-downscaling half (the "before images are massive" file-size complaint) is a larger, separate change and will land in its own follow-up PR — this one alone doesn't fully resolve #6324, so it doesn't carry a closing keyword.
Test plan
test/unit/visual-collapsible.test.tsassertions pass unchanged (the caption is purely additive)npm run typecheckcleannpm run test:cigate green