fix(selfhost): correct stale gittensory_ metric names in .env.example - #6079
Conversation
…JSONbored#5936) The QUEUE_CONCURRENCY tuning comment told operators to watch gittensory_queue_live_pending / gittensory_queue_oldest_live_pending_age_seconds, but neither metric exists under that prefix -- the rebrand only ever registered them as loopover_queue_live_pending / loopover_queue_oldest_live_pending_age_seconds (src/selfhost/metrics.ts). Adds a regression test asserting .env.example never references the stale gittensory_<metric> shape again.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6079 +/- ##
=======================================
Coverage 95.22% 95.23%
=======================================
Files 595 595
Lines 46998 47011 +13
Branches 15015 15015
=======================================
+ Hits 44756 44769 +13
Misses 1493 1493
Partials 749 749
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-15 08:51:04 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 2 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
.env.example'sQUEUE_CONCURRENCYtuning comment told operators to watchgittensory_queue_live_pending/gittensory_queue_oldest_live_pending_age_seconds— neither metric exists under that prefix. The rebrand only ever registeredloopover_queue_live_pending(src/selfhost/metrics.ts) andloopover_queue_oldest_live_pending_age_seconds(same file, and used inprometheus/rules/alerts.yml's real alert expressions).test/unit/env-example-metric-names.test.ts) asserting.env.examplenever references the stalegittensory_<metric>shape again, and positively pins the two corrected metric names.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Closes #5936
Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:cichain's localtsc --noEmitstep OOM-crashes repeatedly regardless of heap tuning (confirmed reproducible even in isolation with a 1.8GB heap). This PR changes zero.ts/.jssource — only.env.example(a comment/config file) and one new self-contained test file using patterns already proven elsewhere in the suite (readFileSync/join/.env.example, mirroringtest/unit/selfhost-grafana-sentry-datasource.test.ts's own.env.exampleassertion). What I could run locally (actionlint,db:migrations:check,git diff --check,npm audit, and the new test in isolation vianpx vitest run) is green; I manually verified the new test actually catches the regression by temporarily reintroducing the stalegittensory_names and confirming it fails, then restored the fix and confirmed it passes. CI'svalidate/validate-code/validate-testschecks run on GitHub's own isolated runners with no such contention and will independently confirm the rest (typecheck included) before merge.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.Not applicable: this is a config-comment + test-only change, no UI/auth/session/API surface touched.
Notes