Skip to content

fix(rebrand): rename gittensory-cli- tmpdir prefix across mcp-cli test family - #5958

Merged
JSONbored merged 1 commit into
mainfrom
fix/mcp-cli-tmpdir-prefix
Jul 15, 2026
Merged

fix(rebrand): rename gittensory-cli- tmpdir prefix across mcp-cli test family#5958
JSONbored merged 1 commit into
mainfrom
fix/mcp-cli-tmpdir-prefix

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • 9 test/unit/mcp-cli-*.test.ts files plus the shared test/unit/support/mcp-cli-harness.ts all used mkdtempSync(tmpdir(), "gittensory-cli-") (and the -tools-/-config- variants) as a human-readable temp-dir label. Purely cosmetic, no cross-references to the exact prefix string anywhere.
  • Completes the gittensory->loopover rebrand for this convention, which the original test-prose sweep missed since it only covered the gittensory-miner/gittensory-ams naming, not gittensory-cli.

Test plan

  • Targeted vitest run across all 9 affected test files -- 77/77 pass
  • Full npm run test:ci gate green locally

…t family

The mcp-cli-*.test.ts files and their shared harness all use
mkdtempSync(tmpdir(), "gittensory-cli-") as a human-readable temp-dir
label -- purely cosmetic, no cross-references. Completes the full-cutover
rename this convention was missed by originally.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@217e96c). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5958   +/-   ##
=======================================
  Coverage        ?   95.15%           
=======================================
  Files           ?      589           
  Lines           ?    46675           
  Branches        ?    14899           
=======================================
  Hits            ?    44414           
  Misses          ?     1511           
  Partials        ?      750           
Flag Coverage Δ
shard-1 43.92% <ø> (?)
shard-2 36.06% <ø> (?)
shard-3 32.07% <ø> (?)
shard-4 32.86% <ø> (?)
shard-5 31.51% <ø> (?)
shard-6 44.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 15, 2026
@loopover-orb

loopover-orb Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-15 01:26:35 UTC

10 files · 1 AI reviewer · 2 blockers · readiness 91/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a pure string-literal rename of the mkdtempSync prefix from "gittensory-cli-" (and the -tools-/-config- variants) to "loopover-cli-" across 9 test files and the shared mcp-cli-harness.ts, matching the description exactly. The prefix is only a human-readable OS temp-dir label with no cross-references elsewhere in the diff, so the change is mechanical and low-risk; test bodies, assertions, and env values are untouched.

Nits — 2 non-blocking
  • Several test files (e.g. test/unit/mcp-cli-review-pr.test.ts, mcp-cli-tools.test.ts) still construct repo strings like "JSONbored/gittensory" inside the diff context — worth confirming those are intentionally out of scope for this rebrand sweep rather than missed.
  • Grep the repo for any remaining "gittensory-cli" or "gittensory-cli-config" / "gittensory-cli-tools" literals outside test/unit to confirm this sweep is complete.

Concerns raised — review before merging

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

2. Maintainer requires a linked issue — Link the relevant issue (for example `Closes #123`) before opening the PR.
Signal Result Evidence
Code review ❌ 2 blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 43 registered-repo PR(s), 35 merged, 411 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 43 PR(s), 411 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Improvement ⚠️ ℹ️ Insufficient signal risk: clean · value: insufficient-signal — Nothing measurable for the structural-improvement analyzers on this PR (e.g. no code files changed). LLM value judgment: minor — The change is a cosmetic tmpdir-prefix rename with no behavioral impact, completing a rebrand naming sweep that was previously incomplete for the mcp-cli test family.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 43 PR(s), 411 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • No action.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 15, 2026
@JSONbored
JSONbored merged commit 92f5ad9 into main Jul 15, 2026
17 checks passed
@JSONbored
JSONbored deleted the fix/mcp-cli-tmpdir-prefix branch July 15, 2026 01:49
This was referenced Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant