Skip to content

docs(core): rename gittensory prose to loopover in remaining src subdirs - #5895

Merged
JSONbored merged 3 commits into
mainfrom
rebrand/prose-remaining-src
Jul 14, 2026
Merged

docs(core): rename gittensory prose to loopover in remaining src subdirs#5895
JSONbored merged 3 commits into
mainfrom
rebrand/prose-remaining-src

Conversation

@JSONbored

@JSONbored JSONbored commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • Part of the gittensory→loopover rebrand (Epic: complete the gittensory -> loopover rebrand (full cutover, no dual-support) #5705), phase 8b: rename brand-name prose in comments across 30 files spanning the remaining src/** subdirectories not covered by the review/signals/selfhost/services batches (api, auth, config, db, env.d.ts, github, index.ts, integrations, notifications, openapi, orb, queue, rules, scoring, server.ts, settings, types.ts, upstream).
  • Not purely comment-only — three hunks change real runtime string literals, each already covered by existing tests that reference the value via its exported symbol (so they stay correct across the rename) or by an updated literal assertion in this same commit:
    • src/github/client.ts: GITHUB_RESPONSE_CACHE_REPLAY_HEADER ("x-gittensory-cache""x-loopover-cache") — a diagnostic cache-hit header used only within this worker's own request/response cycle (never a cross-service contract); every consumer (src/github/graphql-cache.ts, test/unit/github-client.test.ts, test/unit/github-graphql-cache.test.ts) imports the exported constant rather than hardcoding the string, so they stay correct automatically.
    • src/config/gittensory-repo-focus-manifest.ts: GITTENSOR_SELF_REPO_DEFAULT ("JSONbored/gittensory""JSONbored/loopover") — matches the real renamed GitHub repo. test/unit/gittensory-focus-manifest.test.ts asserts against the exported symbol, not a hardcoded literal, so it stays correct. Also required a matching prose rename in the root .loopover.yml (checked byte-identical to this file's bundled YAML constant by the same test) and config/examples/loopover.full.yml's twin .loopover.yml.example — both included here.
    • src/github/e2e-test-commit.ts: defaultE2eTestFilePath (e2e/gittensory-pr-N.spec.tse2e/loopover-pr-N.spec.ts) — the generated e2e test file path committed to a contributor's branch; no external config depends on this specific prefix (verified via repo-wide grep). test/unit/e2e-test-commit.test.ts's two literal-value assertions are updated in this same commit.
  • Includes the matching packages/loopover-engine/src/settings/autonomy.ts twin fix so scripts/check-engine-parity.ts stays passing. src/rules/advisory.ts's prose is deliberately left untouched here — it shares a gate-decision marker pair with packages/loopover-engine/src/advisory/gate-advisory.ts (already renamed in docs(engine): rename gittensory prose to loopover in packages/loopover-engine (batch A) #5897), and the parity script requires both sides change together in one PR; docs(engine): rename gittensory prose to loopover in packages/loopover-engine (batch A) #5897 will own that pair.
  • Deliberately left untouched: GITTENSORY_LEGACY_* check-run name constants, GITTENSORY-[A-Z0-9]+ Sentry issue slugs, the gittensory.aethereal.dev/gittensory-api.aethereal.dev domain aliases, the gittensory-selfhost container-image tag.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves — N/A, maintainer-authored rebrand-epic cleanup (Epic: complete the gittensory -> loopover rebrand (full cutover, no dual-support) #5705), no linked-issue gate applies to owner PRs.

Validation

  • git diff --check
  • npx tsx scripts/check-engine-parity.ts — ok
  • npm run typecheck — clean
  • Targeted vitest runs confirming: test/unit/gittensory-focus-manifest.test.ts (13/13), test/unit/e2e-test-commit.test.ts (10/10), test/unit/config-templates.test.ts (19/19)

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. — N/A, no such changes.
  • API/OpenAPI/MCP behavior is updated and tested where needed — the three functional literal changes above are covered by existing/updated tests.
  • UI changes use live API data or real empty/error/loading states. — N/A, no UI changes.
  • Visible UI changes include a UI Evidence section. — N/A, no UI changes.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs (none touched here).

Notes

@loopover-orb

loopover-orb Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 LoopOver review result - fixes required

Review updated: 2026-07-14 23:44:45 UTC

31 files · 1 AI reviewer · 1 blocker · readiness 77/100 · CI failing · blocked

🛑 Suggested Action - Manual Review

Review summary
This is mostly a straightforward prose rename (gittensory→loopover) inside comments/JSDoc across ~30 files, and the bulk of the diff is indeed comment-only as claimed. However the PR explicitly states 'Comment-only, no behavior change' and 'no coverable lines changed,' but at least three hunks change actual runtime string literals, not comments: the exported HTTP header constant in src/github/client.ts, the self-repo default constant in src/config/gittensory-repo-focus-manifest.ts, and the generated e2e file-path template literal in src/github/e2e-test-commit.ts. These are executable values that change observed behavior and are excluded from the stated comment-only scope, and none of them have accompanying test coverage per the test-evidence list.

Blockers

  • src/github/client.ts: `GITHUB_RESPONSE_CACHE_REPLAY_HEADER` literal changes from `"x-gittensory-cache"` to `"x-loopover-cache"` — this is a wire-visible HTTP header name, not a comment, so any consumer/dashboard/test keyed on the old header value silently breaks, contradicting the PR's 'comment-only, no behavior change' claim.
  • src/config/gittensory-repo-focus-manifest.ts: `GITTENSOR_SELF_REPO_DEFAULT` changes from `"JSONbored/gittensory"` to `"JSONbored/loopover"` — this constant feeds `resolveLoopOverSelfRepoFullName` and drives real self-repo resolution (e.g. drift-issue filing) when `LOOPOVER_DRIFT_ISSUE_REPO` is unset, so it is a functional default change, not prose, and needs its own justification/tests rather than riding along in a 'comment-only' PR.
  • src/github/e2e-test-commit.ts:33: `defaultE2eTestFilePath` now returns `e2e/loopover-pr-${prNumber}.spec.ts` instead of `e2e/gittensory-pr-${prNumber}.spec.ts` — this is the actual generated file path used when committing e2e tests to a contributor's branch, a functional change mislabeled as comment-only with no test covering the new path.
Nits — 6 non-blocking
  • Two near-duplicate copies of the autonomy.ts doc-comment rename (packages/loopover-engine/src/settings/autonomy.ts and src/settings/autonomy.ts) are correctly kept in sync per the stated twin-parity requirement, but it's worth double-checking `check-engine-parity.ts` also asserts full byte-identity beyond just these comment lines.
  • src/openapi/spec.ts: the OpenAPI example value change (`JSONbored/gittensory` → `JSONbored/loopover`) should trigger the generated-artifact regen step (`npm run ui:openapi`) mentioned in the schema-migrations skill — confirm the regenerated output is committed if this changes the emitted spec.
  • Split out the three non-comment literal changes (client.ts header, focus-manifest default, e2e-test-commit path) into a follow-up PR that's explicit about the behavior change, with tests pinning the new values, rather than bundling them into a 'docs(core)'-scoped, comment-only rename PR.
  • Add a regression test asserting `GITHUB_RESPONSE_CACHE_REPLAY_HEADER` and `defaultE2eTestFilePath` produce the new values, since these are now coverable lines under the repo's ~97% branch-counted coverage bar.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.
  • Pull request duplicates other open work — Check for an existing pull request or issue covering this change and coordinate or consolidate before continuing.

Why this is blocked

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

CI checks failing

  • validate
  • validate-code
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 43 registered-repo PR(s), 35 merged, 373 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 43 PR(s), 373 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Improvement ⚠️ ℹ️ None detected risk: low · value: none — No structural-improvement signals were detected for this PR.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 43 PR(s), 373 issue(s).
  • Related work: Titles/paths share 9 meaningful terms. (PR #5897)
  • Related work: Titles/paths share 10 meaningful terms. (PR #5896)
  • Related work: Titles/paths share 9 meaningful terms. (PR #5897, PR #5896)
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Triage stale or unlinked PRs.
  • No action.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

Rebrand cutover cleanup: update brand-name prose in comments across
31 files in src/api, src/auth, src/config, src/db, src/env.d.ts,
src/github, src/index.ts, src/integrations, src/notifications,
src/openapi, src/orb, src/queue, src/rules, src/scoring, src/server.ts,
src/settings, src/types.ts, and src/upstream. Comment-only, no
behavior change. Includes the matching engine-twin fix for
src/settings/autonomy.ts (packages/loopover-engine/src/settings/autonomy.ts)
to keep scripts/check-engine-parity.ts passing.

Deliberate legacy references left untouched: GITTENSORY_LEGACY_*
check-run name constants, GITTENSORY-[A-Z0-9]+ Sentry issue slugs,
the gittensory.aethereal.dev/gittensory-api.aethereal.dev domain
aliases, gittensory-selfhost container-image tag, and the
gittensory-repo-focus-manifest module path (file itself not yet
renamed).
- .loopover.yml: apply the same prose rename as its required-identical
  twin src/config/gittensory-repo-focus-manifest.ts's bundled YAML
  (test/unit/gittensory-focus-manifest.test.ts checks byte-identity).
- test/unit/e2e-test-commit.test.ts: update two assertions to match
  the renamed e2e/loopover-pr-N.spec.ts path (src/github/e2e-test-commit.ts
  is in this batch).
- src/rules/advisory.ts: revert the prose rename here -- it shares a
  gate-decision marker pair with packages/loopover-engine/src/advisory/
  gate-advisory.ts (already renamed in #5897) and scripts/check-engine-parity.ts
  requires both sides change together; #5897 will own this pair instead.
@JSONbored
JSONbored merged commit 682ba5d into main Jul 14, 2026
17 checks passed
@JSONbored
JSONbored deleted the rebrand/prose-remaining-src branch July 14, 2026 23:53
This was referenced Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant