docs: repo-agnostic capability audit for the review/signals/rules stack - #5754
Conversation
Audit src/review, src/signals, and src/rules for hardcoded gittensory-specific assumptions (forge/API hardcodes, the gittensor:* type-label default, branding constants) that would need to become per-tenant configuration before the review/merge authority model can be reused for an arbitrary rented repo. Mirrors the shape of packages/gittensory-miner/docs/repo-agnostic-capability-audit.md (the JSONbored#4780 audit JSONbored#4784 resolved). Audit-and-document only; no code changes. Closes JSONbored#5744
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5754 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 581 581
Lines 46181 46181
Branches 14811 14811
=======================================
Hits 43905 43905
Misses 1516 1516
Partials 760 760
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-14 11:41:55 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #5744.
Audits `src/review/`, `src/signals/`, and `src/rules/` for hardcoded gittensory-specific assumptions that would need to become per-tenant configuration before the review/merge authority model can be handed to an arbitrary rented repo — mirroring the shape of the miner-side
packages/gittensory-miner/docs/repo-agnostic-capability-audit.md(the #4780 audit that #4784 resolved).Audit-and-document only — no code changes (matching #4780's scope split from #4784).
Deliverable
A new audit doc at
src/review/repo-agnostic-capability-audit.mdfollowing #4780's exact format: Summary (3 assumption buckets) → findings-by-file tables (every finding with afile:linereference and aShould becomecolumn) → an "Already parameterized — no follow-up needed" section → a prioritized checklist for the follow-up implementation issue.Findings in brief
api.github.com/2022-11-28/vnd.github+json/ repo-tree + contents path templates hardcoded acrossrag-index.ts,grounding-wire.ts, thevisual/capture+preview sub-system, and thegithub.comweb-URL builders (alerts.ts,changed-files-diff-link.ts,signals/engine.ts).DEFAULT_TYPE_LABELS(gittensor:*) taxonomy fallback atfocus-manifest.ts:550— overridable per repo, gittensory-by-default. This is the review-path item De-hardcode discovery from gittensory's own conventions #4784 explicitly deferred; the acceptance criteria call for it and it is covered here.src/rules/gate logic (engine-delegated), label-propagation matching (config-driven;gittensor:*appears only in comments), the type-label sparse-merge mechanism, and the signals role vocabulary.Every
file:linereference was verified against the currentmain.