fix(review): run AI review for every PR author by default, not just confirmed contributors - #5732
Merged
Merged
Conversation
…onfirmed contributors The confirmedContributor gate on AI review (originally #644, about not applying miner-specific gate rules to non-miner PRs) had been reused to skip the AI-driven defect scan entirely for unconfirmed/new contributors by default -- leaving a new contributor's PR with LESS scrutiny than an established one's, backwards from the intended security posture. AI review now runs for every author once a repo has opted into aiReviewMode, with an explicit opt-in aiReviewConfirmedContributorsOnly setting for self-hosters who deliberately want to bound AI spend to registered miners (aiReviewAllAuthors still widens back out within that narrowed mode).
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | 56c4742 | Commit Preview URL Branch Preview URL |
Jul 14 2026, 09:35 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5732 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 581 581
Lines 46179 46181 +2
Branches 14811 14811
=======================================
+ Hits 43902 43904 +2
Misses 1516 1516
Partials 761 761
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiReviewModeset to something other thanoff. A new opt-inaiReviewConfirmedContributorsOnlysetting lets a self-hoster deliberately narrow back down to confirmed-contributors-only (to bound AI spend);aiReviewAllAuthorsstill widens back out within that narrowed mode, unchanged.resolveAiReviewableAuthorhelper used by both the "should we start a review" gate and the execution-time guard, so the two can no longer drift out of sync.Test plan
npx tsc --noEmitnpx tsx scripts/check-docs-drift.mjsnpm run ui:openapi:settings-parity/npm run ui:openapi:checknpm run test:ci(full local gate, green)resolveAiReviewableAuthor(default-runs-for-everyone + opt-in-narrows) intest/unit/ai-review-advisory.test.tsqueue-3.test.tstests whoseaiCalls === 0assertion was only ever true as a side effect of the bug being fixed (verified the deterministic screenshot-table/contributor-cap gates were never actually wired to suppress AI review -- onlyauthorBlacklistedis, and that test still passes unaffected)settings-preview.test.tscase covering both branches of the new field's nullish fallback