Skip to content

fix(observability): update stale $__all sentinel assertions in maintainer-reviews dashboard test #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 14, 2026
Merged

fix(observability): update stale $__all sentinel assertions in maintainer-reviews dashboard test #5719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/unit/selfhost-grafana-dashboard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function grafanaSqlString(value: string): string {
return `'${value.replaceAll("'", "''")}'`;
}

function expandGrafanaRange(query: string, repo = "$__all"): string {
function expandGrafanaRange(query: string, repo = "__ALL__"): string {
const from = Math.floor(Date.parse("2026-06-29T20:00:00Z") / 1000);
const to = Math.floor(Date.parse("2026-06-29T22:00:00Z") / 1000);
// Every panel's repo variable also needs expanding for a real sqlite3 CLI run, same as the time
Expand Down Expand Up @@ -340,7 +340,7 @@ describe("maintainer Reviews & PRs Grafana dashboard", () => {
expect(target?.queryType).toBe("table");
expect(target?.rawQueryText).toBe(target?.queryText);
expect(target?.queryText).toContain("FROM issues");
expect(target?.queryText).toContain("(${repo:sqlstring} = '$__all' OR repo = ${repo:sqlstring})");
expect(target?.queryText).toContain("(${repo:sqlstring} = '__ALL__' OR repo = ${repo:sqlstring})");
expect(panel?.description?.length ?? 0).toBeGreaterThan(0);
}

Expand All @@ -358,7 +358,7 @@ describe("maintainer Reviews & PRs Grafana dashboard", () => {

it("scopes the issue-activity panels to the selected $repo, same as the PR panels", () => {
for (const id of [12, 13, 14] as const) {
expect(targetForPanel(id).queryText).toContain("(${repo:sqlstring} = '$__all' OR repo = ${repo:sqlstring})");
expect(targetForPanel(id).queryText).toContain("(${repo:sqlstring} = '__ALL__' OR repo = ${repo:sqlstring})");
}
});

Expand All @@ -381,7 +381,7 @@ describe("maintainer Reviews & PRs Grafana dashboard", () => {

expect(targets.length).toBeGreaterThan(0);
for (const target of targets) {
expect(target.queryText).toContain("(${repo:sqlstring} = '$__all' OR repo = ${repo:sqlstring})");
expect(target.queryText).toContain("(${repo:sqlstring} = '__ALL__' OR repo = ${repo:sqlstring})");
expect(target.queryText).not.toContain("'$repo'");
}
});
Expand Down Expand Up @@ -471,7 +471,7 @@ describe("maintainer Reviews & PRs Grafana dashboard", () => {
const trackedQuery = targetForPanel(2).queryText!;
const allRepos = sqlite(db, expandGrafanaRange(trackedQuery));
// A specific repo selection substitutes BOTH repo occurrences with the same SQL-escaped repo value (never
// the literal "$__all" sentinel, which only appears when "All" is selected).
// the literal "__ALL__" sentinel, which only appears when "All" is selected).
const repoAOnly = sqlite(db, expandGrafanaRange(trackedQuery, "owner/repo-a"));
const repoBOnly = sqlite(db, expandGrafanaRange(trackedQuery, "owner/repo-b"));

Expand Down
Loading