fix(queue): migrate signal-snapshot generation from isRegistered to isInstalled

[JSONbored]

Summary

• fanOutRepoSignalSnapshotJobs (src/queue/processors.ts) gated per-repo signal-snapshot generation on repo.isRegistered, even though most of what it generates (queue-health, config-quality, label-audit, contributor-intake-health, issue-quality, repo-outcome-patterns) is general repo health, unrelated to gittensor-subnet membership.
• The maintainer-lane/maintainer-cut-readiness pieces are genuinely gittensor-specific but already degrade gracefully for !isRegistered internally — no other change needed there.
• generateSignalSnapshots (src/queue/signal-snapshot.ts) — the function the enqueued job actually calls — independently re-filters by the same field. Both filters needed the swap; fixing only the outer one (as the issue's own text specified) would enqueue a job that silently no-ops once it reaches this second filter.

Test plan

• Regression tests: an installed-but-not-registered repo gets a signal-snapshot job enqueued (outer filter) and a real snapshot generated (inner filter); a registered-but-not-installed repo gets neither
• npm run test:ci — full local gate, clean (0 failures)

Closes #5019

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.02%. Comparing base (21d13b2) to head (a3ac8cf).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5692   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         577      577           
  Lines       45978    45978           
  Branches    14724    14724           
=======================================
  Hits        43689    43689           
  Misses       1530     1530           
  Partials      759      759           

Flag	Coverage Δ
shard-1	43.63% <100.00%> (-0.42%)	⬇️
shard-2	35.84% <0.00%> (+0.06%)	⬆️
shard-3	32.33% <0.00%> (-0.09%)	⬇️
shard-4	33.04% <0.00%> (-0.02%)	⬇️
shard-5	31.51% <0.00%> (-0.26%)	⬇️
shard-6	44.62% <0.00%> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/queue/processors.ts	95.67% <100.00%> (ø)
src/queue/signal-snapshot.ts	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ LoopOver review result - manual review recommended

_{Review updated: 2026-07-14 05:34:24 UTC}

4 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

⏸️ Suggested Action - Manual Review

• Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): src/queue/processors.ts (matched src/queue/**), src/queue/signal-snapshot.ts (matched src/queue/**).

Review summary
This PR swaps the gating field from `isRegistered` to `isInstalled` in both `fanOutRepoSignalSnapshotJobs` and `generateSignalSnapshots`, correctly identifying that the enqueue-side filter alone would be insufficient since the consumer re-filters independently by the same field. The description explicitly calls out this two-layer trap and the tests cover both filters plus the negative case (registered-but-not-installed gets nothing), which is exactly the right regression coverage for this kind of wiring bug. Closes #5019, is narrowly scoped, and CI is green across the board.

Nits — 6 non-blocking

• src/queue/processors.ts and src/queue/signal-snapshot.ts: the inline comments duplicate the PR description almost verbatim — consider trimming to a one-liner pointing at Migrate signal-snapshot generation from isRegistered to isInstalled #5019 rather than restating the full rationale in two places.
• test/unit/queue.test.ts: the trend-snapshot date change from 2026-05-25 to 2026-05-23 in an unrelated assertion block isn't explained — worth a one-line comment on why that shift was needed alongside the isInstalled fixture changes.
• Consider grepping the codebase for any other consumers of the enqueued generate-signal-snapshots job or similar isRegistered filters (e.g. maintainer-lane logic) to confirm no third gating point was missed.
• Since the PR notes maintainer-lane/maintainer-cut-readiness already degrade gracefully for !isRegistered, a quick test asserting that behavior explicitly would strengthen confidence that no follow-up regression is needed there.
• PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
• Touches a guarded path — held for manual review — A maintainer must review and merge this change.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#5019
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 45 registered-repo PR(s), 37 merged, 320 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 45 PR(s), 320 issue(s).
Gate result	⚠️ Not blocking	Advisory; not blocking this PR.
Improvement	✅ Minor	risk: clean · value: minor — Code changes are accompanied by test evidence.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
• Official Gittensor activity: 45 PR(s), 320 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
• @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review