fix(queue): widen rag-index fan-out to match the regate-sweep candidate set - #5686
Conversation
…te set fanOutRagIndexJobs still filtered candidates to isRegistered repos unioned with the LOOPOVER_REVIEW_REPOS allowlist, unlike fanOutAgentRegateSweepJobs which unions ALL listRepositories(). An installed-but-never-registered, non-allowlisted repo (the brokered self-host case) was never a fan-out candidate, so a per-repo features.rag override could never resurface it — the repo was still reviewed via the regate sweep, just without codebase- context retrieval. Drop the isRegistered filter so the candidate set matches the regate sweep exactly; convergedFeatureActive still gates the actual indexing spend, so this only widens eligibility. Closes #5024
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5686 +/- ##
==========================================
- Coverage 95.04% 95.04% -0.01%
==========================================
Files 576 576
Lines 45977 45976 -1
Branches 14724 14724
==========================================
- Hits 43699 43698 -1
Misses 1525 1525
Partials 753 753
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-14 04:05:24 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
fanOutRagIndexJobs(the RAG-index cron fan-out) built its candidate pool fromisRegisteredrepos UNION theLOOPOVER_REVIEW_REPOSallowlist, unlikefanOutAgentRegateSweepJobs(the regate sweep) which unions ALLlistRepositories(). An installed-but-never-registered, non-allowlisted repo (the brokered self-host case:is_registered=0) was never even a fan-out candidate, so a per-repofeatures.ragmanifest override could never resurface it — the repo still got reviewed via the regate sweep, just without codebase-context retrieval.isRegisteredfilter so the candidate set matchesfanOutAgentRegateSweepJobsexactly: ALL known repos UNION the allowlist. The existingconvergedFeatureActive(env, repo, "rag")filter is untouched, so this widens ELIGIBILITY only, not indexing spend.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateSafety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. (N/A — backend-only change, no visible UI surface.)UI Evidence
N/A — backend-only change to the RAG-index cron fan-out candidate resolution; no UI surface.
Notes
test/unit/rag-index.test.ts: an installed (installationIdset), non-registered, non-allowlisted repo with afeatures.rag: truemanifest override is now included in the cron fan-out, matchingfanOutAgentRegateSweepJobs's coverage. Verified the new test fails on the pre-fix code and passes after.Closes #5024