refactor(engine): extract shared telemetry-anonymization primitive - #5683
Conversation
Orb's self-host collector hand-rolled its own per-instance HMAC anonymization with no reusable module. AMS is about to need the identical pattern to safely export its own telemetry (#5681) -- pulling it into @loopover/engine now means one implementation instead of two independently-maintained copies of security-sensitive anonymization logic. Closes #5680
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | 85c798a | Commit Preview URL Branch Preview URL |
Jul 14 2026, 02:28 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5683 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 576 577 +1
Lines 45991 45992 +1
Branches 14724 14724
=======================================
+ Hits 43713 43714 +1
Misses 1525 1525
Partials 753 753
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-14 02:40:32 UTC
⏸️ Suggested Action - Manual Review
Review summary Blockers
Nits — 7 non-blocking
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Re: the flagged "blocker" about the relative-path import being the likely cause of the The actual failure (see the job log) was The relative-path import itself ( Leaving the code as-is. Held for manual review per the guarded-path policy, which is correct — over to a maintainer to merge. |
Summary
src/selfhost/orb-collector.ts) hand-rolled its own per-instance-secret HMAC anonymization with no reusable module.packages/gittensory-engine/src/telemetry/anonymize.tsexportsgenerateAnonSecret/hmacAnonymize(pure, no I/O);orb-collector.tsre-wired onto it with a fixed-vector regression test asserting identical output to the pre-extraction implementation.Test plan
npm run build --workspace @loopover/enginecleannode:testsuite: 550/550 passnpx tsc --noEmit --incremental falsecleantest/unit/engine-telemetry-anonymize.test.ts+test/unit/selfhost-orb-collector.test.ts(21/21 pass, confirms zero behavior change to Orb's live export)npm run test:coverage(unsharded): both changed files at 100% line/branch/function coverage percoverage/lcov.infoCloses #5680