Skip to content

test(miner-governor): close codecov/patch gap on kill-switch's repoFullName fallback #5047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 11, 2026
Merged

test(miner-governor): close codecov/patch gap on kill-switch's repoFullName fallback #5047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions test/unit/miner-governor-kill-switch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,23 @@ describe("recordMinerKillSwitchTransition (#2341)", () => {
expect(rows[0]?.id).toBeLessThan(rows[1]?.id ?? 0);
});

it("a transition with no repoFullName supplied records a null repoFullName, not an omitted or undefined one", () => {
const root = mkdtempSync(join(tmpdir(), "gittensory-miner-governor-kill-switch-no-repo-"));
roots.push(root);
const ledger = initGovernorLedger(join(root, "governor-ledger.sqlite3"));
ledgers.push(ledger);

const tripped = recordMinerKillSwitchTransition(
{ actionClass: "open_pr", previousScope: "none", scope: "global" },
{ append: (event) => ledger.appendGovernorEvent(event) },
);

expect(tripped?.repoFullName).toBeNull();
const rows = ledger.readGovernorEvents({});
expect(rows).toHaveLength(1);
expect(rows[0]?.repoFullName).toBeNull();
});

it("is a no-op and appends nothing when the scope has not changed", () => {
const root = mkdtempSync(join(tmpdir(), "gittensory-miner-governor-kill-switch-noop-"));
roots.push(root);
Expand Down