Skip to content

fix(comments): keep repo outcome patterns out of public duplicate checks - #493

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-outcome-patterns-leak-in-comments
Jun 10, 2026
Merged

fix(comments): keep repo outcome patterns out of public duplicate checks#493
JSONbored merged 1 commit into
mainfrom
codex/fix-outcome-patterns-leak-in-comments

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Repo outcome-pattern details (path/label buckets and merge-rate counts) were copied into generic riskReasons/whyThisHelps and could be surfaced by the public @gittensory duplicate-check renderer, leaking authenticated repo-specific guidance and contributor-controlled path/label text.

Description

  • Stop folding repoOutcomePatterns detail lines into the generic riskReasons and whyThisHelps arrays so outcome patterns remain available only via the dedicated repoOutcomePatterns field in decision packs.
  • Harden duplicate-check rendering by introducing isPublicDuplicateCautionLine and mentionsRepoOutcomePatternDetail to filter out repo outcome-pattern detail strings before selecting or publishing caution lines.
  • Make mentionsDuplicateRisk use the same public-safe filter so cached action records containing outcome-pattern text are not treated as public duplicate/WIP signals.
  • Add/adjust unit tests to assert repo outcome patterns stay scoped to the private field and that duplicate-check comments do not publish merge/closure guidance or pattern text.

Testing

  • Ran targeted unit tests with npm test -- --run test/unit/decision-pack.test.ts test/unit/github-commands.test.ts and all tests in those suites passed.
  • Ran TypeScript typecheck with npm run typecheck and the project passed type checking.
  • Verified repository diff/checks (git diff --check / local test runs) showed no lint/type regressions.

Codex Task

@ghost

ghost commented Jun 9, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #493 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 9, 2026
@ghost ghost added the gittensory:reviewed label Jun 9, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui bf31590 Commit Preview URL

Branch Preview URL
Jun 10 2026, 06:41 AM

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jun 10, 2026
@JSONbored JSONbored changed the title fix: keep repo outcome patterns out of public duplicate checks fix(comments): keep repo outcome patterns out of public duplicate checks Jun 10, 2026
@JSONbored
JSONbored force-pushed the codex/fix-outcome-patterns-leak-in-comments branch 2 times, most recently from 2f482ce to 38ea88e Compare June 10, 2026 06:37
@JSONbored
JSONbored force-pushed the codex/fix-outcome-patterns-leak-in-comments branch from 38ea88e to bf31590 Compare June 10, 2026 06:39
@JSONbored
JSONbored merged commit 0910a17 into main Jun 10, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/fix-outcome-patterns-leak-in-comments branch June 10, 2026 06:44
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 10, 2026
@JSONbored JSONbored added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jun 10, 2026
@github-actions github-actions Bot mentioned this pull request Jun 10, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant