Skip to content

fix(api): scope app command feedback by repo access #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jun 10, 2026
Merged

fix(api): scope app command feedback by repo access #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/api/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,6 +1086,11 @@ export function createApp() {
if (!parsed.success) return c.json({ error: "invalid_command_feedback", issues: parsed.error.issues }, 400);
const answer = await getAgentCommandAnswer(c.env, parsed.data.answerId);
if (!answer) return c.json({ error: "command_answer_not_found" }, 404);
const repo = await getRepository(c.env, answer.repoFullName);
if (identity.kind === "session") {
const repoForbidden = await requireSessionRepoAccess(c, identity, answer.repoFullName, repo);
if (repoForbidden) return repoForbidden;
}
const actorLogin = identity.actor;
await recordAgentCommandFeedback(c.env, {
answerId: answer.id,
Expand Down
47 changes: 47 additions & 0 deletions test/integration/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1803,6 +1803,53 @@ describe("api routes", () => {
);
expect(forbiddenVictimPreview.status).toBe(403);
await expect(forbiddenVictimPreview.json()).resolves.toMatchObject({ error: "forbidden_repo" });
await upsertAgentCommandAnswer(ownerEnv, {
id: "owned-app-feedback",
repoFullName: "repo-owner/owned-repo",
issueNumber: 7,
command: "plan-next-work",
requestCommentId: 700,
responseCommentId: 701,
responseUrl: "https://github.com/repo-owner/owned-repo/pull/7#issuecomment-701",
actorKind: "maintainer",
createdAt: "2026-05-28T00:00:00.000Z",
updatedAt: "2026-05-28T00:00:00.000Z",
metadata: {},
});
await upsertAgentCommandAnswer(ownerEnv, {
id: "victim-app-feedback",
repoFullName: "victim-org/secret-repo",
issueNumber: 42,
command: "plan-next-work",
requestCommentId: 4200,
responseCommentId: 4201,
responseUrl: "https://github.com/victim-org/secret-repo/pull/42#issuecomment-4201",
actorKind: "maintainer",
createdAt: "2026-05-28T00:00:00.000Z",
updatedAt: "2026-05-28T00:00:00.000Z",
metadata: {},
});
const ownerRepoFeedback = await app.request(
"/v1/app/commands/feedback",
{
method: "POST",
headers: ownerHeaders,
body: JSON.stringify({ answerId: "owned-app-feedback", vote: "useful" }),
},
ownerEnv,
);
expect(ownerRepoFeedback.status).toBe(200);
const forbiddenVictimFeedback = await app.request(
"/v1/app/commands/feedback",
{
method: "POST",
headers: ownerHeaders,
body: JSON.stringify({ answerId: "victim-app-feedback", vote: "not_useful" }),
},
ownerEnv,
);
expect(forbiddenVictimFeedback.status).toBe(403);
await expect(forbiddenVictimFeedback.json()).resolves.toMatchObject({ error: "forbidden_repo" });
const { token: operatorToken } = await createSessionForGitHubUser(ownerEnv, { login: "jsonbored", id: 1 });
const operatorVictimPreview = await app.request(
"/v1/app/commands/preview",
Expand Down