Skip to content

fix(github-app): preserve gate blocking defaults - #488

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-gate-migration-disabling-blockers
Jun 10, 2026
Merged

fix(github-app): preserve gate blocking defaults#488
JSONbored merged 1 commit into
mainfrom
codex/fix-gate-migration-disabling-blockers

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Prevent silent policy bypass introduced by migrating linked_issue_gate_mode and duplicate_pr_gate_mode to advisory, which caused formerly required Gate checks to become non-blocking after upgrade.
  • Restore prior merge hygiene behavior for repositories that had gateCheckMode enabled without requiring an operator change.

Description

  • Change DB migration and schema defaults for linked_issue_gate_mode and duplicate_pr_gate_mode from advisory back to block by updating migrations/0023_gate_quality_modes.sql and src/db/schema.ts.
  • Add a follow-up migration migrations/0025_restore_gate_blocking_modes.sql that updates existing repository_settings rows to restore block for those fields when gate_check_mode = 'enabled'.
  • Update runtime/default handling in src/db/repositories.ts and API parsing defaults in src/api/routes.ts so omitted settings preserve legacy blocking behavior (default to block when not explicitly set).
  • Make gate evaluation treat omitted per-rule modes as legacy block by default in src/rules/advisory.ts while still honoring explicit advisory and off values, and update Gate check copy in src/github/app.ts and unit tests to reflect the preserved behavior.

Testing

  • Ran targeted unit tests with vitest for rules, GitHub app, and queue: all targeted tests passed.
  • Ran full unit test suite with npm run test:unit: all unit tests passed.
  • Ran type checking with tsc --noEmit and OpenAPI generation check with the UI openapi script: both succeeded.

Codex Task

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui e2bda37 Commit Preview URL

Branch Preview URL
Jun 10 2026, 06:19 AM

@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 9, 2026
@ghost

ghost commented Jun 9, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #488 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 9, 2026
@ghost ghost mentioned this pull request Jun 9, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored
JSONbored force-pushed the codex/fix-gate-migration-disabling-blockers branch from f3ae060 to e2bda37 Compare June 10, 2026 06:17
@JSONbored
JSONbored merged commit df3f13b into main Jun 10, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/fix-gate-migration-disabling-blockers branch June 10, 2026 06:20
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant