Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/queue/processors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,10 @@ import {
releaseTransientLockIfOwner,
type TransientLockClaim,
} from "./transient-locks";
// #4013 step 1: temporary re-export shim so test/unit/queue.test.ts's existing
// #4013 step 1: temporary re-export shim so test/unit/queue.test.ts and its size-split siblings
// (queue-2/3/4/5.test.ts, queue-lifecycle-guards.test.ts)'s existing
// `import { claimPrActuationLock, releasePrActuationLock } from "../../src/queue/processors"` keeps working
// unchanged -- those tests are deeply interspersed with unrelated ones in that file, not in a cleanly
// unchanged -- those tests are deeply interspersed with unrelated ones in that file family, not in a cleanly
// extractable describe block, so relocating them is deliberately deferred rather than forced into this PR.
export { claimPrActuationLock, releasePrActuationLock } from "./transient-locks";
import { isVisualPath } from "../review/visual/paths";
Expand Down Expand Up @@ -14418,8 +14419,8 @@ async function closeReviewEvasionSelfCloseIfActive(
// rethrow) IS reachable and IS exercised by the existing re-close-failure tests -- only the else branch
// (this `if`'s implicit non-Error path) and the fallback statement below are ignored. Concretely: a 500
// from GitHub on the re-close PATCH makes closePullRequest reject with a RequestError, which is exactly
// what test/unit/queue.test.ts's "REGRESSION (gate-flagged): a retry after the re-close failure
// converges -- the PR ends up closed, and the strike is recorded exactly once" drives through this `if`.
// what test/unit/queue-lifecycle-guards.test.ts's "REGRESSION (gate-flagged): a retry after the re-close
// failure converges -- the PR ends up closed, and the strike is recorded exactly once" drives through this `if`.
/* v8 ignore else */
if (closeError instanceof Error) throw closeError;
/* v8 ignore next -- unreachable, see above. */
Expand Down
2,565 changes: 2,565 additions & 0 deletions test/unit/backfill-2.test.ts

Large diffs are not rendered by default.

2,560 changes: 77 additions & 2,483 deletions test/unit/backfill.test.ts

Large diffs are not rendered by default.

5,352 changes: 5,352 additions & 0 deletions test/unit/queue-2.test.ts

Large diffs are not rendered by default.

5,158 changes: 5,158 additions & 0 deletions test/unit/queue-3.test.ts

Large diffs are not rendered by default.

7,002 changes: 7,002 additions & 0 deletions test/unit/queue-4.test.ts

Large diffs are not rendered by default.

5,969 changes: 5,969 additions & 0 deletions test/unit/queue-5.test.ts

Large diffs are not rendered by default.

4,839 changes: 4,839 additions & 0 deletions test/unit/queue-lifecycle-guards.test.ts

Large diffs are not rendered by default.

27,354 changes: 113 additions & 27,241 deletions test/unit/queue.test.ts

Large diffs are not rendered by default.