Skip to content

fix(settings): require issues:write for detected comment mode independent of sample #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 5 commits into from
Jun 8, 2026
Merged

fix(settings): require issues:write for detected comment mode independent of sample #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5049be4
fix(settings): require issues:write for detected comment mode indepen…
philluiz2323 Jun 7, 2026
48fbeac
Merge branch 'main' into fix/install-preview-comment-permission
JSONbored Jun 8, 2026
f3e16bf
ci: retry actionlint binary downloads
galuis116 Jun 8, 2026
523db4f
Merge remote-tracking branch 'upstream/main' into pr-468-fix-ci
galuis116 Jun 8, 2026
40ce537
Merge branch 'main' into fix/install-preview-comment-permission
JSONbored Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/signals/settings-preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ function buildRepoInstallPreview(args: {
}

function writesPrPublicSurface(settings: RepositorySettings, decision: PublicSurfaceDecision): boolean {
return decision.willComment || decision.willLabel || shouldPublishPrComment(settings) || shouldApplyPrLabel(settings, "confirmed");
return decision.willComment || decision.willLabel || shouldPublishPrComment(settings, "confirmed") || shouldApplyPrLabel(settings, "confirmed");
}

function requiredInstallPermissions(settings: RepositorySettings, decision: PublicSurfaceDecision): string[] {
Expand Down
15 changes: 15 additions & 0 deletions test/unit/settings-preview.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,21 @@ describe("buildRepoSettingsPreview", () => {
expect(withoutChecks.warnings.some((warning) => /Checks: write/.test(warning))).toBe(false);
});

it("requires Issues: write for detected-contributors comment mode even when previewing a non-confirmed sample", () => {
// detected_contributors_only + comment_only comments for confirmed miners, so the repo needs
// issues:write regardless of the previewed sample's miner status. Previewing a non-confirmed
// author must not drop the required (and missing) issues permission.
const preview = buildRepoSettingsPreview({
...base,
settings: settings({ publicSurface: "comment_only", commentMode: "detected_contributors_only", autoLabelEnabled: false, publicAudienceMode: "oss_maintainer" }),
installation: { ...healthyInstall, status: "needs_attention", missingPermissions: ["issues"] },
sample: { authorLogin: "contributor", minerStatus: "not_found" },
});
expect(preview.decision).toMatchObject({ skipped: false, willComment: false, willLabel: false });
expect(preview.installPreview.permissions.required).toContain("issues: write");
expect(preview.installPreview.permissions.missing).toContain("issues");
});

it("explains a missing Checks: write permission when the opt-in gate is enabled", () => {
const preview = buildRepoSettingsPreview({
...base,
Expand Down