feat(miner-hands): CLI-subprocess CodingAgentDriver

[jeffrey701]

Closes #4266

What

Implements the CodingAgentDriver seam (#4262) by running the coding agent (claude/codex) as a subprocess in the attempt's scoped working directory. The spawn primitive is injected — a generalized version of src/selfhost/ai.ts's SpawnFn, redeclared here so gittensory-engine stays standalone (no import from src/) — so the driver is fully testable without a real child process.

Reuses the shared safety primitives (not duplicated)

Both come from subprocess-env.ts (#4284), the engine-hosted source of truth:

• Strict allowlisted env via buildAllowlistedEnv + SUBPROCESS_CLI_ENV_ALLOWLIST — the child gets only home/proxy/TLS/locale/XDG keys plus caller-supplied extras, never the full host env (a coding-agent subprocess is prompt-injectable, so runtime credentials must not leak into it).
• redactSecrets — any subprocess output kept as a transcript or folded into an error is redacted first (well-known token shapes + a caller-supplied knownSecrets list).

Behavior

• Exit 0 → ok: true.
• Non-zero/absent exit code → ok: false with a redacted <command>_exit_<code>: <detail> error (falls back to exit <code> when the subprocess wrote no stderr).
• Timeout → ok: false with a distinct <command>_timeout_<ms>ms error.
• Detecting which files changed is a sibling concern (a git diff over the worktree, feat(miner-hands): git-worktree-per-attempt isolation primitive #4269), so changedFiles is [].

API (packages/gittensory-engine/src/miner/cli-subprocess-driver.ts)

createCliSubprocessCodingAgentDriver(options) → CodingAgentDriver, with CliSubprocessSpawnFn (the injectable spawn type) and CliSubprocessDriverOptions (command, spawn, timeoutMs, parentEnv/env, knownSecrets, and an overridable buildArgs).

Testing

npx vitest run test/unit/cli-subprocess-driver.test.ts
npm run typecheck

6/6 tests pass (success, non-zero-exit redaction, no-stderr fallback incl. a null code, timeout, env-allowlisting, secret-redaction + custom argv) via an injected fake spawn; typecheck clean. New engine file at 100% line + branch coverage (18/18, 18/18, 3/3).

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.04%. Comparing base (363305c) to head (b503aa6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4524   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files         422      423    +1     
  Lines       37574    37592   +18     
  Branches    13724    13732    +8     
=======================================
+ Hits        35335    35353   +18     
  Misses       1583     1583           
  Partials      656      656           

Files with missing lines	Coverage Δ
...ttensory-engine/src/miner/cli-subprocess-driver.ts	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

_{Review updated: 2026-07-09 22:56:06 UTC}

3 files · 1 blocker · readiness 82/100 · CI green · unstable

🛑 Suggested Action - Reject/Close

• AI review already in progress for this PR head: Another Gittensory pass is already running the AI review for this exact PR head. This pass is skipping to avoid a duplicate LLM call.

Review summary
AI review is already running for this PR head in another Gittensory pass. Gittensory is holding this PR for manual review until that pass completes.

Nits — 1 non-blocking

• AI review already in progress for this PR head — The gate is held for a human reviewer rather than passed automatically; it re-evaluates once the in-flight review completes or on the next update.

Why this is blocked

• Possible leaked secret in the diff (generic_secret_assignment) — Remove the secret from the diff, rotate the exposed credential, then re-run the gate.

Signal	Result	Evidence
Code review	❌ 1 blocker	No AI review summary
Linked issue	✅ Linked	#4266
Related work	⚠️ 1 scoped overlap	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 106 registered-repo PR(s), 45 merged, 4 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	jeffrey701; Gittensor profile; 106 PR(s), 4 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.

Linked issue satisfaction

Partially addressed
The PR delivers the CodingAgentDriver seam with an injected subprocess spawn function, env allowlisting, redaction, and the required fake-SpawnFn tests (success, non-zero exit, timeout, secret redaction), but it uses a single flat `timeoutMs` default rather than the per-effort timeout ladder pattern the issue explicitly asks it to mirror, and its generic `buildArgs` placeholder never addresses or

Review context

• Author: jeffrey701
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 106 PR(s), 4 issue(s).
• Related work: Titles/paths share 6 meaningful terms. (issue #4307, issue #4266)

Contributor next steps

• Review top overlaps.
• Add a concise scope and risk note.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[loopover-orb]

Gittensory is closing this pull request on the maintainer's behalf (Possible leaked secret in the diff (generic_secret_assignment)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.