feat(review): register e2eTests as the sixth converged-feature key - #4206
Merged
Conversation
Extends the existing rag/reputation/unifiedComment/safety/grounding converged-feature registry with a new e2eTests key (env kill-switch -> per-repo features override -> allowlist default), gating the upcoming AI-generated E2E test coverage feature (#4189). Plain symmetric override, no force-on/force-off asymmetry needed. Wires the new GITTENSORY_REVIEW_E2E_TESTS flag through wrangler.jsonc, env.d.ts, and the regenerated worker-configuration.d.ts, and documents it in the public/self-host config examples and the docs site's feature-flag pages. Closes #4190, #4192 (the originally separate resolver-gate issue collapses into this one: every other converged feature is resolved directly via resolveConvergedFeature/ convergedFeatureActive at call sites, with no per-feature wrapper, so e2eTests follows that same established shape).
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 1c29a6b | Commit Preview URL Branch Preview URL |
Jul 08 2026, 11:28 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
=======================================
Coverage 93.74% 93.74%
=======================================
Files 387 388 +1
Lines 36420 36421 +1
Branches 13341 13342 +1
=======================================
+ Hits 34142 34143 +1
Misses 1621 1621
Partials 657 657
🚀 New features to boost your workflow:
|
12 tasks
21 tasks
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2eTestsas the sixth converged-feature key (alongsiderag/reputation/unifiedComment/safety/grounding) in the shared config-as-code registry, gated by a newGITTENSORY_REVIEW_E2E_TESTSmaster kill-switch. This is the foundational config piece for the AI-generated E2E test coverage epic (Epic: AI-generated E2E test coverage for pull requests #4189) — pure schema/plumbing, no generation logic yet.safety/groundinghave) — generating AI test content carries no security-hardening rationale to protect from a repo-controlled override.wrangler.jsonc,src/env.d.ts, and the regeneratedworker-configuration.d.ts; documents it in.gittensory.yml.example, both self-host config examples, and the docs site's feature-flag reference pages.resolveConvergedFeature/convergedFeatureActiveat call sites, with no per-feature wrapper file —e2eTestsfollows that same established shape, so a redundant wrapper isn't needed.Closes #4190, #4192.
Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally (unsharded) — new code (src/review/e2e-test-gen-wire.ts) is 100% covered (both the nullish and present branches of the env-flag regex check); existing generic converged-feature tests (test/unit/feature-activation.test.ts) automatically exercise the new key since they iterateCONVERGED_FEATURE_KEYS.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderatenpm run test:cigate end-to-end (all steps: db migrations/schema-drift checks, selfhost env-reference + observability validation, cf-typegen check, engine/mcp/miner build+pack, REES suite, docs-drift + manifest-drift + command-reference checks, ui build) — all green.Safety
UI Evidencesection — skipped: the only UI-adjacent change is two new one-line<li>bullet entries on existing docs pages (docs.tuning.tsx,docs.privacy-security.tsx), matching the exact existing list pattern for every otherGITTENSORY_REVIEW_*flag — no new visual state, layout, or component, so a before/after screenshot wouldn't show anything a diff doesn't already.CHANGELOG.mditself is untouched, as required.Notes
GITTENSORY_REVIEW_E2E_TESTSdefaults to"false"inwrangler.jsonc) — zero behavior change until a future PR in the Epic: AI-generated E2E test coverage for pull requests #4189 epic adds actual generation/render/dispatch logic behind this gate.packages/gittensory-engine/dist/build from before this session, unrelated to this PR's content) by rebuilding the package — not part of this diff, just noting it for anyone else hitting the same stale-dist symptom on a fresh checkout.