Skip to content

feat(review): register e2eTests as the sixth converged-feature key - #4206

Merged
JSONbored merged 1 commit into
mainfrom
feat/e2e-test-gen-converged-feature-key
Jul 8, 2026
Merged

feat(review): register e2eTests as the sixth converged-feature key#4206
JSONbored merged 1 commit into
mainfrom
feat/e2e-test-gen-converged-feature-key

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • Registers e2eTests as the sixth converged-feature key (alongside rag/reputation/unifiedComment/safety/grounding) in the shared config-as-code registry, gated by a new GITTENSORY_REVIEW_E2E_TESTS master kill-switch. This is the foundational config piece for the AI-generated E2E test coverage epic (Epic: AI-generated E2E test coverage for pull requests #4189) — pure schema/plumbing, no generation logic yet.
  • Plain symmetric override (no force-on/force-off asymmetry like safety/grounding have) — generating AI test content carries no security-hardening rationale to protect from a repo-controlled override.
  • Wires the new env var through wrangler.jsonc, src/env.d.ts, and the regenerated worker-configuration.d.ts; documents it in .gittensory.yml.example, both self-host config examples, and the docs site's feature-flag reference pages.
  • The originally separate "resolver gate" issue (feat(review): resolver gate for e2eTests — src/review/e2e-test-gen.ts #4192) collapses into this PR: every other converged feature is resolved directly via resolveConvergedFeature/convergedFeatureActive at call sites, with no per-feature wrapper file — e2eTests follows that same established shape, so a redundant wrapper isn't needed.

Closes #4190, #4192.

Scope

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally (unsharded) — new code (src/review/e2e-test-gen-wire.ts) is 100% covered (both the nullish and present branches of the env-flag regex check); existing generic converged-feature tests (test/unit/feature-activation.test.ts) automatically exercise the new key since they iterate CONVERGED_FEATURE_KEYS.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries
  • Also ran the full npm run test:ci gate end-to-end (all steps: db migrations/schema-drift checks, selfhost env-reference + observability validation, cf-typegen check, engine/mcp/miner build+pack, REES suite, docs-drift + manifest-drift + command-reference checks, ui build) — all green.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. — N/A, no auth/session/CORS surface touched.
  • API/OpenAPI/MCP behavior is updated and tested where needed — N/A for this PR (no new API/OpenAPI surface; this is config-schema plumbing only).
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section — skipped: the only UI-adjacent change is two new one-line <li> bullet entries on existing docs pages (docs.tuning.tsx, docs.privacy-security.tsx), matching the exact existing list pattern for every other GITTENSORY_REVIEW_* flag — no new visual state, layout, or component, so a before/after screenshot wouldn't show anything a diff doesn't already.
  • Public docs/changelogs are updated where needed (the two docs pages above); CHANGELOG.md itself is untouched, as required.

Notes

  • This PR ships the feature fully OFF by default (GITTENSORY_REVIEW_E2E_TESTS defaults to "false" in wrangler.jsonc) — zero behavior change until a future PR in the Epic: AI-generated E2E test coverage for pull requests #4189 epic adds actual generation/render/dispatch logic behind this gate.
  • Also fixed one pre-existing environment issue encountered locally (a stale packages/gittensory-engine/dist/ build from before this session, unrelated to this PR's content) by rebuilding the package — not part of this diff, just noting it for anyone else hitting the same stale-dist symptom on a fresh checkout.

Extends the existing rag/reputation/unifiedComment/safety/grounding converged-feature
registry with a new e2eTests key (env kill-switch -> per-repo features override ->
allowlist default), gating the upcoming AI-generated E2E test coverage feature (#4189).
Plain symmetric override, no force-on/force-off asymmetry needed. Wires the new
GITTENSORY_REVIEW_E2E_TESTS flag through wrangler.jsonc, env.d.ts, and the regenerated
worker-configuration.d.ts, and documents it in the public/self-host config examples and
the docs site's feature-flag pages.

Closes #4190, #4192 (the originally separate resolver-gate issue collapses into this one:
every other converged feature is resolved directly via resolveConvergedFeature/
convergedFeatureActive at call sites, with no per-feature wrapper, so e2eTests follows
that same established shape).
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 1c29a6b Commit Preview URL

Branch Preview URL
Jul 08 2026, 11:28 AM

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.74%. Comparing base (acc37e0) to head (1c29a6b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4206   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         387      388    +1     
  Lines       36420    36421    +1     
  Branches    13341    13342    +1     
=======================================
+ Hits        34142    34143    +1     
  Misses       1621     1621           
  Partials      657      657           
Files with missing lines Coverage Δ
packages/gittensory-engine/src/focus-manifest.ts 99.16% <100.00%> (ø)
src/review/e2e-test-gen-wire.ts 100.00% <100.00%> (ø)
src/review/feature-activation.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored
JSONbored merged commit 0cb6854 into main Jul 8, 2026
12 checks passed
@JSONbored
JSONbored deleted the feat/e2e-test-gen-converged-feature-key branch July 8, 2026 11:37
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(review): resolver gate for e2eTests — src/review/e2e-test-gen.ts feat(review): register e2eTests as the sixth converged-feature key

1 participant