Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gittensory.yml.example
Original file line number Diff line number Diff line change
Expand Up @@ -607,9 +607,6 @@ settings:
# Bool. Default: true.
backfillEnabled: true

# Use private trust signals in scoring. Bool. Default: true.
privateTrustEnabled: true

# Render a README status badge for the repo. Bool. Default: false.
badgeEnabled: false

Expand Down
4 changes: 0 additions & 4 deletions apps/gittensory-ui/public/openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -8895,9 +8895,6 @@
"backfillEnabled": {
"type": "boolean"
},
"privateTrustEnabled": {
"type": "boolean"
},
"badgeEnabled": {
"type": "boolean"
},
Expand Down Expand Up @@ -9336,7 +9333,6 @@
"includeMaintainerAuthors",
"requireLinkedIssue",
"backfillEnabled",
"privateTrustEnabled",
"commandAuthorization"
]
},
Expand Down
7 changes: 3 additions & 4 deletions apps/gittensory-ui/src/routes/docs.tuning.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -464,10 +464,9 @@ function Tuning() {
<li>
<code>includeMaintainerAuthors</code> (default <code>false</code>),{" "}
<code>requireLinkedIssue</code> (default <code>false</code>), <code>backfillEnabled</code>{" "}
(default <code>true</code>), <code>privateTrustEnabled</code> (default <code>true</code>),
and <code>badgeEnabled</code> (README status badge, default <code>false</code>), and{" "}
<code>publicQualityMetrics</code> (public review-quality page, default <code>false</code>
).
(default <code>true</code>), and <code>badgeEnabled</code> (README status badge, default{" "}
<code>false</code>), and <code>publicQualityMetrics</code> (public review-quality page,
default <code>false</code>).
</li>
<li>
<code>agentPaused</code> (per-repo kill-switch, default <code>false</code>) and{" "}
Expand Down
3 changes: 0 additions & 3 deletions config/examples/gittensory.full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -620,9 +620,6 @@ settings:
# Bool. Default: true.
backfillEnabled: true

# Use private trust signals in scoring. Bool. Default: true.
privateTrustEnabled: true

# Render a README status badge for the repo. Bool. Default: false.
badgeEnabled: false

Expand Down
6 changes: 6 additions & 0 deletions migrations/0122_drop_private_trust_enabled.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
-- Dead-code cleanup (#4012). private_trust_enabled was persisted and exposed via the maintainer settings
-- API but read by zero conditional logic anywhere in src/ -- only ever assigned and passed through. Its doc
-- comment described gating "private trust signals in scoring", which this repo's house rules explicitly
-- forbid wiring in (no trust scores / reward values anywhere), so the correct disposition is removal, not
-- implementation. SQLite 3.35+ / D1 supports DROP COLUMN directly.
ALTER TABLE repository_settings DROP COLUMN private_trust_enabled;
3 changes: 1 addition & 2 deletions packages/gittensory-engine/src/focus-manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,6 @@ export type FocusManifestSettings = Partial<
| "includeMaintainerAuthors"
| "requireLinkedIssue"
| "backfillEnabled"
| "privateTrustEnabled"
| "autonomy"
| "autoMaintain"
| "agentPaused"
Expand Down Expand Up @@ -1535,7 +1534,7 @@ function parseSettingsOverride(value: JsonValue | undefined, warnings: string[])
}
const publicSurface = normalizeOptionalEnum(r.publicSurface, "settings.publicSurface", ["off", "comment_and_label", "comment_only", "label_only"] as const, warnings);
if (publicSurface !== null) out.publicSurface = publicSurface;
for (const key of ["aiReviewByok", "aiReviewAllAuthors", "closeOwnerAuthors", "autoLabelEnabled", "typeLabelsEnabled", "badgeEnabled", "publicQualityMetrics", "createMissingLabel", "includeMaintainerAuthors", "requireLinkedIssue", "backfillEnabled", "privateTrustEnabled", "agentPaused", "agentDryRun"] as const) {
for (const key of ["aiReviewByok", "aiReviewAllAuthors", "closeOwnerAuthors", "autoLabelEnabled", "typeLabelsEnabled", "badgeEnabled", "publicQualityMetrics", "createMissingLabel", "includeMaintainerAuthors", "requireLinkedIssue", "backfillEnabled", "agentPaused", "agentDryRun"] as const) {
const flag = normalizeOptionalBoolean(r[key], `settings.${key}`, warnings);
if (flag !== null) out[key] = flag;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,6 @@ export type RepositorySettings = {
includeMaintainerAuthors: boolean;
requireLinkedIssue: boolean;
backfillEnabled: boolean;
privateTrustEnabled: boolean;
/** Opt-in for the public, unauthenticated README status badge (#541). Always populated by the DB layer
* (default false); optional so existing settings fixtures/callers need not be touched. */
badgeEnabled?: boolean | undefined;
Expand Down
8 changes: 3 additions & 5 deletions src/api/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,6 @@ const repositorySettingsSchema = z.object({
includeMaintainerAuthors: z.boolean().default(false),
requireLinkedIssue: z.boolean().default(false),
backfillEnabled: z.boolean().default(true),
privateTrustEnabled: z.boolean().default(true),
badgeEnabled: z.boolean().default(false),
publicQualityMetrics: z.boolean().default(false),
commandAuthorization: z
Expand All @@ -700,9 +699,9 @@ const repositorySettingsSchema = z.object({

// #130 maintainer self-serve settings editor. A PATCH-style subset: every field optional so the maintainer
// dashboard can save just the group it changed. Excludes the secret-bearing aiReview* group (set via the
// dedicated /ai-review + /ai-key routes) and the operator-only scoring internals (backfillEnabled,
// privateTrustEnabled). The handler loads current settings and merges, since upsertRepositorySettings
// defaults any absent field rather than preserving it.
// dedicated /ai-review + /ai-key routes) and the operator-only scoring internal (backfillEnabled). The
// handler loads current settings and merges, since upsertRepositorySettings defaults any absent field
// rather than preserving it.
const maintainerSettingsSchema = z
.object({
commentMode: z.enum(["off", "detected_contributors_only", "all_prs"]),
Expand Down Expand Up @@ -3823,7 +3822,6 @@ export function createApp() {
includeMaintainerAuthors: parsed.data.includeMaintainerAuthors,
requireLinkedIssue: parsed.data.requireLinkedIssue,
backfillEnabled: parsed.data.backfillEnabled,
privateTrustEnabled: parsed.data.privateTrustEnabled,
badgeEnabled: parsed.data.badgeEnabled,
publicQualityMetrics: parsed.data.publicQualityMetrics,
commandAuthorization: normalizeCommandAuthorizationPolicy(parsed.data.commandAuthorization).policy,
Expand Down
40 changes: 0 additions & 40 deletions src/api/workboard.ts

This file was deleted.

7 changes: 1 addition & 6 deletions src/db/repositories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,6 @@ export async function getRepositorySettings(env: Env, fullName: string): Promise
includeMaintainerAuthors: false,
requireLinkedIssue: false,
backfillEnabled: true,
privateTrustEnabled: true,
badgeEnabled: false,
publicQualityMetrics: false,
agentPaused: false,
Expand Down Expand Up @@ -612,7 +611,6 @@ export async function getRepositorySettings(env: Env, fullName: string): Promise
includeMaintainerAuthors: row.includeMaintainerAuthors,
requireLinkedIssue: row.requireLinkedIssue,
backfillEnabled: row.backfillEnabled,
privateTrustEnabled: row.privateTrustEnabled,
badgeEnabled: row.badgeEnabled,
publicQualityMetrics: row.publicQualityMetrics,
agentPaused: row.agentPaused,
Expand Down Expand Up @@ -733,7 +731,6 @@ export async function upsertRepositorySettings(env: Env, settings: Partial<Repos
includeMaintainerAuthors: settings.includeMaintainerAuthors ?? false,
requireLinkedIssue: settings.requireLinkedIssue ?? false,
backfillEnabled: settings.backfillEnabled ?? true,
privateTrustEnabled: settings.privateTrustEnabled ?? true,
badgeEnabled: settings.badgeEnabled ?? false,
publicQualityMetrics: settings.publicQualityMetrics ?? false,
agentPaused: settings.agentPaused ?? false,
Expand Down Expand Up @@ -813,7 +810,6 @@ export async function upsertRepositorySettings(env: Env, settings: Partial<Repos
includeMaintainerAuthors: resolved.includeMaintainerAuthors,
requireLinkedIssue: resolved.requireLinkedIssue,
backfillEnabled: resolved.backfillEnabled,
privateTrustEnabled: resolved.privateTrustEnabled,
badgeEnabled: resolved.badgeEnabled,
publicQualityMetrics: resolved.publicQualityMetrics,
agentPaused: resolved.agentPaused,
Expand Down Expand Up @@ -897,9 +893,8 @@ export async function upsertRepositorySettings(env: Env, settings: Partial<Repos
includeMaintainerAuthors: resolved.includeMaintainerAuthors,
requireLinkedIssue: resolved.requireLinkedIssue,
backfillEnabled: resolved.backfillEnabled,
privateTrustEnabled: resolved.privateTrustEnabled,
badgeEnabled: resolved.badgeEnabled,
publicQualityMetrics: resolved.publicQualityMetrics,
publicQualityMetrics: resolved.publicQualityMetrics,
agentPaused: resolved.agentPaused,
agentDryRun: resolved.agentDryRun,
commandAuthorizationJson: jsonString(resolved.commandAuthorization),
Expand Down
1 change: 0 additions & 1 deletion src/db/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ export const repositorySettings = sqliteTable("repository_settings", {
includeMaintainerAuthors: integer("include_maintainer_authors", { mode: "boolean" }).notNull().default(false),
requireLinkedIssue: integer("require_linked_issue", { mode: "boolean" }).notNull().default(false),
backfillEnabled: integer("backfill_enabled", { mode: "boolean" }).notNull().default(true),
privateTrustEnabled: integer("private_trust_enabled", { mode: "boolean" }).notNull().default(true),
badgeEnabled: integer("badge_enabled", { mode: "boolean" }).notNull().default(false),
publicQualityMetrics: integer("public_quality_metrics", { mode: "boolean" }).notNull().default(false),
commandAuthorizationJson: text("command_authorization_json").notNull().default("{}"),
Expand Down
1 change: 0 additions & 1 deletion src/openapi/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,6 @@ export const RepositorySettingsSchema = z
includeMaintainerAuthors: z.boolean(),
requireLinkedIssue: z.boolean(),
backfillEnabled: z.boolean(),
privateTrustEnabled: z.boolean(),
badgeEnabled: z.boolean().optional(),
publicQualityMetrics: z.boolean().optional(),
commandAuthorization: z.object({
Expand Down
1 change: 1 addition & 0 deletions src/review/issue-rag-wire.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function cleanLabels(labels: string[] | undefined): string[] {
.slice(0, MAX_ISSUE_LABELS);
}

// Intentionally pre-built and currently unreached: no miner-side issue-analysis caller exists yet (#2320).
export function buildIssueRagQuery(input: IssueRagQueryInput): { queryText: string } {
const sections: string[] = [];
const title = input.title.trim();
Expand Down
43 changes: 0 additions & 43 deletions src/review/labeling-rules.ts

This file was deleted.

Loading
Loading