fix(ci): build engine package before running backend tests - #4036
Merged
Conversation
src/mcp/find-opportunities.ts imports packages/gittensory-miner/lib/opportunity-fanout.js (committed, pre-built), which imports @jsonbored/gittensory-engine. That package's dist/ is gitignored and only exists after the 'Build engine package' step, but the step ran after 'Test with coverage' and was gated on the narrow packages/gittensory-engine/** path filter, so any backend PR that didn't touch the engine package directly failed to resolve it.
loopover-orb
Bot
added
the
gittensor:bug
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4036 +/- ##
=======================================
Coverage ? 93.58%
=======================================
Files ? 381
Lines ? 35483
Branches ? 13014
=======================================
Hits ? 33206
Misses ? 1617
Partials ? 660 🚀 New features to boost your workflow:
|
This was referenced Jul 7, 2026
JSONbored
added a commit
that referenced
this pull request
Jul 8, 2026
…4081) (#4084) src/mcp/find-opportunities.ts (since #3986) imports packages/gittensory-miner/lib/ opportunity-fanout.js (committed, pre-built), which imports @jsonbored/gittensory-engine. That package's dist/ is gitignored and only exists after an explicit build step -- Cloudflare's Workers Builds pipeline for gittensory-api runs npm run deploy:api directly with no such step, so wrangler deploy's bundler has failed to resolve the import on every push to main since 487d26a (2026-07-07T09:36:46Z). Mirrors the identical fix already applied to the self-host image build (#4034), the release build (#4063), and the backend test suite (#4036).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/mcp/find-opportunities.ts(root backend file) importspackages/gittensory-miner/lib/opportunity-fanout.js(committed, pre-built JS), which itself imports@jsonbored/gittensory-engine.@jsonbored/gittensory-engine'sdist/output is gitignored and only exists after the "Build engine package" CI step runs.Test with coverageand was gated only on the narrowpackages/gittensory-engine/**path filter — so any ordinary backend PR that didn't touch the engine package directly failed withFailed to resolve entry for package "@jsonbored/gittensory-engine"across ~48 test suites.Typecheck(before test execution) and widened its trigger to also fire on anybackendpath change, in addition topushand the existingenginepath filter.Test plan
npm run actionlint— cleanrm -rf packages/gittensory-engine/dist && npx vitest run test/unit/mcp-server-telemetry.test.tsfailed identically to the CI log