fix(signals): single-source isCodeFile via isSourcePath and add .kts - #3887
fix(signals): single-source isCodeFile via isSourcePath and add .kts#3887RealDiligent wants to merge 2 commits into
Conversation
Delegate path-matchers and engine isCodeFile to isSourcePath so the JVM/.NET/Swift/Groovy/Kotlin-script source set stays symmetric with isTestPath and cannot drift. Adds .kts source classification so Gradle Kotlin-script changes are no longer invisible to missing-tests gates. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Add a buildPreflightResult regression so engine.ts inheriting path-matchers isCodeFile (and its .g.dart/.freezed.dart exclusion) stays covered at the signals layer. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-07 05:24:29 UTC
🛑 Suggested Action - Reject/Close
Review summary Blockers
Nits — 5 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue; AI reviewers agree on a likely critical defect: The PR description explicitly states 'No linked issue' — this repo's contributor policy requires every external PR to close or clearly link an eligible open issue before merge, and none is provided here.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3887 +/- ##
=======================================
Coverage 93.57% 93.57%
=======================================
Files 340 340
Lines 33516 33516
Branches 12262 12263 +1
=======================================
Hits 31364 31364
Misses 1528 1528
Partials 624 624
🚀 New features to boost your workflow:
|
Summary
isSourcePathintest-evidence.tsas the canonical source-side matcher symmetric withisTestPathfor JVM/.NET/Swift/Groovy/Kotlin-script files.path-matchers.tsandengine.tsisCodeFiletoisSourcePath(plus the existing extended native/front-end/Dart extensions) so the classifiers cannot drift..ktsGradle Kotlin-script source so untested changes no longer escape missing-tests gate signals.No linked issue: classifier symmetry bugfix —
isTestPathalready recognizes.ktstest files, butisCodeFileomitted.ktssource, letting untested Gradle Kotlin-script changes bypass missing-tests gates. Small, self-contained fix with regression tests only.Validation
npm test -- test/unit/test-evidence.test.ts test/unit/local-branch-file-classifiers.test.ts test/unit/path-matchers.test.ts test/unit/signals.test.ts(138 tests passed locally)validate-code+validategreen on this PRSafety
.ktssource and consolidates duplicate matchers.