feat(agent): add recommendation snapshot ids - #374
Merged
JSONbored merged 3 commits intoJun 4, 2026
Conversation
JSONbored
approved these changes
Jun 4, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@bitloi this is ready from my side.
A few notes:
- The snapshot ID behavior is narrowly scoped and avoids pulling in the broader replay/migration work.
- The branch is locally merge-clean against current main.
- No code changes requested.
Validation expected:
- Keep the current green CI run after any required branch update.
Closed
12 tasks
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recommendationSnapshotIdplus a public-saferecommendationSnapshotenvelope to every persisted agent action emitted by the supported agent paths.Related: #311 overlaps this area but bundles #281-#285 plus migrations and replay APIs. This PR keeps #281 focused on the id/envelope only.
Scope
CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally; global coverage stays at or above 97% for lines, statements, functions, and branches (aim for 98%+ branch coverage locally so CI variance does not fail near the threshold)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateAdditional focused checks:
npm run test -- test/unit/recommendation-snapshots.test.tsnpm run test -- test/integration/api.test.ts -t "serves deterministic signal endpoints"npm run typechecknpm run test:ciIf any required check was skipped, explain why:
Safety
Notes
payload.recommendationSnapshotId.