fix(signals): classify Perl and Scala protobuf stubs as generated - #3715
Conversation
Recognize protoc Perl *_pb.pm and Scala .pb.scala output in isGeneratedFile so generated-only diffs classify correctly for slop signals and the changed-files summary classifier dependency. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-06 06:06:14 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3715 +/- ##
=======================================
Coverage 93.36% 93.36%
=======================================
Files 315 315
Lines 32204 32204
Branches 11812 11812
=======================================
Hits 30066 30066
Misses 1507 1507
Partials 631 631
🚀 New features to boost your workflow:
|
Summary
Extend
isGeneratedFileto recognize protoc Perl message stubs (*_pb.pm) and Scala message stubs (.pb.scala), matching the existing.pb.*plugin coverage for Go/TS/JS/C++/Rust/Elixir/etc. Includes positive/negativeisGeneratedFile/classifyChangedFileassertions and classification-table entries.Fixes #2144
Scope
CONTRIBUTING.md.classifyChangedFile).Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesisGeneratedFile,classifyChangedFile, and the representative cases tableIf any required check was skipped, explain why:
Safety
UI Evidence
N/A — signals-only change with no visible UI.
Notes
Incremental path-matcher parity supporting the changed-files summary pipeline (#2144). Does not deliver
summarizeChangedFilesgrouping — only closes generated-classification gaps for Perl/Scala protoc output.Conflict avoidance: Touches only
src/signals/path-matchers.tsandtest/unit/path-matchers.test.ts. Zero overlap with open PRs (#3714 config docs, #3712 visual shot bounds, #3704 miner calibration types, #3702 miner README, #3698 ignored-author gate, #3688 scroll GIF capture).Made with Cursor