Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/gittensory-engine/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,4 @@ export {
type MetadataCandidateIssue,
type MetadataRankContext,
} from "./opportunity-metadata.js";
export { pickTopMetadataOpportunities } from "./metadata-top-pick.js";
21 changes: 21 additions & 0 deletions packages/gittensory-engine/src/metadata-top-pick.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import {
rankMetadataOpportunities,
type MetadataCandidateIssue,
type MetadataRankContext,
} from "./opportunity-metadata.js";
import type { OpportunityRankInput } from "./opportunity-ranker.js";

/**
* Rank metadata candidates and return the top `limit` entries. Non-finite or negative limits return an empty list.
* Pure — delegates to {@link rankMetadataOpportunities} for target filtering, scoring, and tie-breaking.
*/
export function pickTopMetadataOpportunities<T extends MetadataCandidateIssue>(
candidates: readonly T[],
context: MetadataRankContext,
limit: number,
): Array<T & OpportunityRankInput & { rankScore: number }> {
if (!Number.isFinite(limit)) return [];
const safeLimit = Math.max(0, Math.trunc(limit));
if (safeLimit === 0 || candidates.length === 0) return [];
return rankMetadataOpportunities(candidates, context).slice(0, safeLimit);
}
45 changes: 45 additions & 0 deletions test/unit/opportunity-metadata-signals.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
opportunityMetadataInternals,
rankMetadataOpportunities,
} from "../../packages/gittensory-engine/src/opportunity-metadata";
import { pickTopMetadataOpportunities } from "../../packages/gittensory-engine/src/metadata-top-pick";
import { DEFAULT_MINER_GOAL_SPEC } from "../../packages/gittensory-engine/src/miner-goal-spec";
import { computeOpportunityCompetition } from "../../packages/gittensory-engine/src/opportunity-competition";
import { computeOpportunityFreshness } from "../../packages/gittensory-engine/src/opportunity-freshness";
Expand Down Expand Up @@ -120,6 +121,50 @@ describe("opportunity metadata signals", () => {
expect(ranked.map((entry) => entry.issueNumber)).toEqual([1, 2]);
});

it("pickTopMetadataOpportunities returns the highest-scoring metadata candidates up to the limit", () => {
const candidates = [
{ ...base, issueNumber: 1, labels: ["wontfix"] },
{ ...base, issueNumber: 2, labels: ["help wanted"] },
{ ...base, issueNumber: 3, labels: ["help wanted", "bug"] },
];
const topTwo = pickTopMetadataOpportunities(candidates, { nowMs: NOW }, 2);
expect(topTwo.map((entry) => entry.issueNumber)).toEqual([3, 2]);
expect(topTwo[0]!.rankScore).toBeGreaterThan(topTwo[1]!.rankScore);
});

it("pickTopMetadataOpportunities skips miner-disabled repos before slicing", () => {
const candidates = [
{ ...base, issueNumber: 1, repoFullName: "acme/disabled" },
{ ...base, issueNumber: 2, labels: ["help wanted"] },
];
const ranked = pickTopMetadataOpportunities(candidates, {
nowMs: NOW,
goalSpecsByRepo: {
"acme/disabled": { ...DEFAULT_MINER_GOAL_SPEC, minerEnabled: false },
},
}, 5);
expect(ranked.map((entry) => entry.issueNumber)).toEqual([2]);
});

it("pickTopMetadataOpportunities returns an empty list for invalid limits or no candidates", () => {
const candidates = [{ ...base, issueNumber: 1 }];
expect(pickTopMetadataOpportunities(candidates, { nowMs: NOW }, 0)).toEqual([]);
expect(pickTopMetadataOpportunities(candidates, { nowMs: NOW }, -1)).toEqual([]);
expect(pickTopMetadataOpportunities(candidates, { nowMs: NOW }, Number.NaN)).toEqual([]);
expect(pickTopMetadataOpportunities([], { nowMs: NOW }, 3)).toEqual([]);
});

it("pickTopMetadataOpportunities is exported from the package barrel", async () => {
const barrel = await import("../../packages/gittensory-engine/src/index");
expect(typeof barrel.pickTopMetadataOpportunities).toBe("function");
const top = barrel.pickTopMetadataOpportunities(
[{ ...base, issueNumber: 9, labels: ["help wanted"] }],
{ nowMs: NOW },
1,
);
expect(top.map((entry) => entry.issueNumber)).toEqual([9]);
});

it("freshness and competition helpers stay pure with injected clocks and safe inputs", () => {
expect(computeOpportunityFreshness([{ state: "closed", updatedAt: "2026-07-03T00:00:00.000Z" }], NOW)).toBe(0);
expect(computeOpportunityCompetition(Number.NaN, 3)).toBe(1);
Expand Down
Loading