Skip to content

fix(mcp): remove default profile session cleanly #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jun 3, 2026
Merged

fix(mcp): remove default profile session cleanly #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/gittensory-mcp/bin/gittensory-mcp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,8 @@ function removeProfile(currentConfig, profileName) {
delete profiles[profileName];
const remaining = Object.keys(profiles);
const activeProfile = currentConfig.activeProfile === profileName ? (profiles[defaultProfileName] ? defaultProfileName : remaining[0] ?? defaultProfileName) : currentConfig.activeProfile;
return normalizeConfig({ ...currentConfig, activeProfile, profiles });
const session = profileName === defaultProfileName ? undefined : currentConfig.session;
return normalizeConfig({ ...currentConfig, activeProfile, profiles, session });
}

function hasPersistedConfigState(currentConfig) {
Expand Down
32 changes: 32 additions & 0 deletions test/unit/mcp-cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,38 @@ describe("gittensory-mcp CLI", () => {
expect(requests).toEqual(expect.arrayContaining([expect.objectContaining({ url: "/v1/auth/session", authorization: "Bearer session-okto" })]));
});

it("removes the default profile without rehydrating its legacy session token", async () => {
tempDir = mkdtempSync(join(tmpdir(), "gittensory-cli-"));
const configPath = join(tempDir, "config.json");
writeFileSync(
configPath,
JSON.stringify(
{
apiUrl: "https://api.example.test",
activeProfile: "default",
profiles: {
default: { session: { token: "default-session-token", login: "default-user", scopes: [] } },
beta: { session: { token: "beta-session-token", login: "beta-user", scopes: [] } },
},
session: { token: "default-session-token", login: "default-user", scopes: [] },
},
null,
2,
),
);

const removed = JSON.parse(await runAsync(["profile", "remove", "default", "--json"], { GITTENSORY_CONFIG_DIR: tempDir })) as { status: string; removedProfile: string; activeProfile: string };
const saved = JSON.parse(readFileSync(configPath, "utf8")) as { activeProfile: string; profiles?: Record<string, unknown>; session?: unknown };

expect(removed).toMatchObject({ status: "removed", removedProfile: "default", activeProfile: "beta" });
expect(saved.activeProfile).toBe("beta");
expect(saved.profiles).not.toHaveProperty("default");
expect(saved.profiles).toHaveProperty("beta");
expect(saved.session).toBeUndefined();
expect(JSON.stringify(saved)).not.toContain("default-session-token");
expect(JSON.stringify(saved)).toContain("beta-session-token");
});

it("logs out only the selected profile and reports missing profiles safely", async () => {
tempDir = mkdtempSync(join(tmpdir(), "gittensory-cli-"));
const requests: Array<{ url: string | undefined; authorization: string | undefined }> = [];
Expand Down