Skip to content

fix(selfhost): regenerate stale env-var reference line numbers - #3181

Merged
JSONbored merged 1 commit into
mainfrom
fix/selfhost-env-reference-stale-lines-2
Jul 4, 2026
Merged

fix(selfhost): regenerate stale env-var reference line numbers#3181
JSONbored merged 1 commit into
mainfrom
fix/selfhost-env-reference-stale-lines-2

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • apps/gittensory-ui/src/lib/selfhost-env-reference.ts (generated by scripts/gen-selfhost-env-reference.mjs) drifted stale again after #3058 ("AI provider fallback chains") shifted line numbers in src/selfhost/ai.ts without regenerating the reference. npm run selfhost:env-reference:check now fails on a clean main checkout.
  • Pure regeneration (npm run selfhost:env-reference), no manual edits — same fix pattern as an earlier occurrence today (docs(gittensory-ui): fix stale website docs and add a CI docs-drift check #3059), now recurring since a different PR touched the same line-number-sensitive source files.

Scope

  • Conventional Commit title.
  • Focused: one generated file, zero logic changes.
  • Follows CONTRIBUTING.md.
  • No linked issue needed — trivial generated-artifact regen, caught by direct npm run test:ci inspection.

Validation

  • git diff --check
  • npm run test:ci — full run, exit 0, 8653 passed / 7 skipped across 431 files
  • npm run selfhost:env-reference:check — now passes
  • npm audit --audit-level=moderate — 0 vulnerabilities

Safety

  • No secrets/wallets/hotkeys/trust scores.
  • N/A — pure generated-file regen, no behavior change.

UI Evidence

N/A — a generated reference table's line-number annotations, no visual/UI change.

Notes

This is the second time this exact drift has recurred today, from two different PRs touching src/selfhost/**. Worth considering whether selfhost:env-reference:check should be a required branch-protection status check on its own (separate from the aggregate validate-code job) so it's harder for a merge to silently reintroduce staleness — noting this for awareness, not proposing it as part of this PR.

apps/gittensory-ui/src/lib/selfhost-env-reference.ts drifted again
after #3058 (AI provider fallback chains) shifted line numbers in
src/selfhost/ai.ts without regenerating the reference, breaking
npm run selfhost:env-reference:check on a clean main checkout. Pure
regeneration via npm run selfhost:env-reference, no manual edits.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 437162e Commit Preview URL

Branch Preview URL
Jul 04 2026, 07:17 PM

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 4, 2026
@loopover-orb

loopover-orb Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-04 19:18:27 UTC

1 file · 1 AI reviewer · 1 blocker · readiness 93/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • Maintainer test expectations unmet — Add or update tests, or attach passing validation output that satisfies the maintainer's test expectations.

Review summary
This is a focused regeneration of `apps/gittensory-ui/src/lib/selfhost-env-reference.ts` that keeps the row objects and markdown table in sync after upstream line-number drift in `src/server.ts`. The changed references move consistently by one line in both exported representations, and the generated-file contract is preserved with no logic or runtime behavior changes. Given the passing generated-reference check and the full post-change file content, I do not see a correctness issue in this diff.

Nits — 1 non-blocking
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Concerns raised — review before merging

  • Maintainer test expectations unmet — Add or update tests, or attach passing validation output that satisfies the maintainer's test expectations.
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 60 registered-repo PR(s), 50 merged, 442 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 60 PR(s), 442 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 60 PR(s), 442 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • No action.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor manual-review Gittensor contributor context labels Jul 4, 2026
@JSONbored JSONbored self-assigned this Jul 4, 2026
@JSONbored
JSONbored merged commit 408ea48 into main Jul 4, 2026
10 checks passed
@JSONbored
JSONbored deleted the fix/selfhost-env-reference-stale-lines-2 branch July 4, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Development

Successfully merging this pull request may close these issues.

1 participant