fix(agent-actions): scope live CI close recheck

[JSONbored]

Motivation

• A recent executor guard re-fetched live CI for any close action tagged closeKind: "heuristic", which incorrectly required live CI to still be failed for all heuristic closes and thus blocked non-CI-driven closes (gate failures, slop/duplicate findings, conflicts) when CI had become passing.
• The intent is to re-check CI only for merges and for closes that were specifically driven by red CI, not for every heuristic close the planner emits.

Description

• Add a narrow discriminator closeRequiresCiState?: "failed" to the planned action payload (PlannedAgentAction) and the persisted approval params (AgentPendingActionParams) so CI-driven closes can carry an explicit CI dependency.
• Populate closeRequiresCiState: "failed" in the planner only when the computed close reason is actually a CI failure (ciFailed).
• Scope the executor's actuation-time live-CI recheck to merge actions and only to close actions that carry closeRequiresCiState === "failed", while keeping the broader closeKind: "heuristic" value for the close-precision breaker.
• Persist and round-trip the new closeRequiresCiState through actionParams() and pendingActionToPlanned() so queued/accepted closes retain the CI dependency; update comments and type docs accordingly.
• Update and extend unit tests to cover CI-driven close denial/proceed paths, queued replay round-trip, non-CI heuristic closes, and the planner's behavior for CI vs non-CI closes.

Testing

• Ran the updated unit tests via vitest for the changed suites: test/unit/agent-action-executor.test.ts, test/unit/agent-actions.test.ts, and test/unit/agent-approval-queue.test.ts, and they all passed locally.
• Type checking with tsc --noEmit completed successfully.
• Ran git diff --check with no issues reported.
• npm run test:ci could not complete in this environment due to network/setup limits affecting actionlint and the repository's self-hosted runner label, and npm audit --audit-level=moderate could not complete because the audit endpoint returned 403 Forbidden.

---

Codex Task

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-02 07:37:35 UTC}

6 files · 1 AI reviewer · no blockers · readiness 95/100 · CI pending · blocked

⏸️ Suggested Action - Manual Review

• Touches a guarded path — held for manual review

Review summary
The change cleanly separates broad heuristic-close classification from the narrower red-CI dependency, and the executor now preserves the old fail-closed behavior only for legacy staged heuristic closes where the new discriminator is absent. The planner writes an explicit `failed` versus `not_required` value for fresh heuristic closes, and `actionParams()` persists the discriminator so queued CI-driven closes still re-check live CI before mutation. The visible tests cover the important live, replayed, non-CI, and legacy paths, so the diff is safe enough to proceed.

Nits — 5 non-blocking

• nit: `src/settings/agent-actions.ts:67` documents `closeRequiresCiState` as always set for heuristic closes, but the optional field leaves that convention unenforced outside `planAgentMaintenanceActions`; consider a discriminated helper/type if more call sites construct `PlannedAgentAction` directly.
• nit: `test/unit/agent-approval-queue.test.ts:889` only asserts `actionParams()` persistence for `closeRequiresCiState: "failed"`; adding the `"not_required"` case would pin the non-CI queued replay contract too.
• In `test/unit/agent-approval-queue.test.ts:889`, add a companion assertion for `{ closeKind: "heuristic", closeRequiresCiState: "not_required" }` so the persisted non-CI discriminator cannot regress.
• In `src/settings/agent-actions.ts:67`, either enforce heuristic close construction through the planner/helper or tighten the type shape so fresh heuristic closes cannot accidentally omit `closeRequiresCiState` while legacy replay remains explicitly represented.
• Touches a guarded path — held for manual review — A maintainer must review and merge this change.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ No-issue rationale	PR body explains why no issue is linked.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (size label size:M; no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 65 registered-repo PR(s), 55 merged, 548 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 65 PR(s), 548 issue(s).
Gate result	⚠️ Not blocking	Advisory; not blocking this PR.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 65 PR(s), 548 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Triage stale or unlinked PRs.
• No action.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	gittensory-ui	ab246a0	Commit Preview URL Branch Preview URL	Jul 02 2026, 05:43 AM

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.96%. Comparing base (4101ca6) to head (82b7bbf).
⚠️ Report is 39 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2478      +/-   ##
==========================================
+ Coverage   95.94%   95.96%   +0.01%     
==========================================
  Files         226      226              
  Lines       25361    25473     +112     
  Branches     9229     9266      +37     
==========================================
+ Hits        24333    24445     +112     
  Misses        417      417              
  Partials      611      611              

Files with missing lines	Coverage Δ
src/services/agent-action-executor.ts	93.44% <100.00%> (+0.64%)	⬆️
src/settings/agent-actions.ts	93.04% <100.00%> (+0.25%)	⬆️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.