Skip to content

fix(queue): bound linked-issue webhook fanout by queuing staggered per-PR jobs #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 2, 2026
Merged

fix(queue): bound linked-issue webhook fanout by queuing staggered per-PR jobs #2476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/queue/processors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2753,8 +2753,9 @@ async function maybeReReviewOnCiCompletion(
* Wake linked PRs on an issue-side signal (#2259). Labeling/unlabeling (e.g. maintainer-only) or
* assigning/unassigning on a linked ISSUE can flip a linked-issue hard-rule verdict, but that only gets
* re-evaluated when the PR ITSELF receives a webhook or the staleness-ordered sweep eventually reaches it —
* which can lag for many cycles on a repo with more than a few open PRs. Re-review every OPEN PR that links
* this issue promptly instead of waiting. Uses its OWN coalesce window (issueLinkedPrReReviewCoalesced,
* which can lag for many cycles on a repo with more than a few open PRs. Enqueue a bounded, staggered batch of
* per-PR re-gate jobs for OPEN PRs that link this issue instead of doing the expensive live re-review inline.
* Uses its OWN coalesce window (issueLinkedPrReReviewCoalesced,
* DISTINCT from CI-completion's — #2371): the two triggers are not interchangeable, so a shared window let an
* unrelated CI re-review silently suppress a genuinely different issue-side signal. Within the issue-side
* window itself, same-PR events are ALSO not interchangeable (an add-then-remove or assign-then-unassign
Expand Down Expand Up @@ -2783,8 +2784,9 @@ async function maybeReReviewOnLinkedIssueChange(
const openPullRequests = await listOpenPullRequests(env, repoFullName);
const linkingPrNumbers = openPullRequests
.filter((pr) => pr.linkedIssues.includes(issueNumber))
.map((pr) => pr.number);
for (const prNumber of linkingPrNumbers) {
.map((pr) => pr.number)
.slice(0, SWEEP_MAX_PRS);
for (const [index, prNumber] of linkingPrNumbers.entries()) {
if (await issueLinkedPrReReviewCoalesced(env, repoFullName, prNumber)) {
await scheduleTrailingIssueLinkedReReview(
env,
Expand All @@ -2795,13 +2797,17 @@ async function maybeReReviewOnLinkedIssueChange(
);
continue;
}
await reReviewStoredPullRequest(
env,
const job: JobMessage = {
type: "agent-regate-pr",
deliveryId,
installationId,
repoFullName,
prNumber,
);
installationId,
};
const delaySeconds = Math.min(index * 10, 600);
await (delaySeconds > 0
? env.JOBS.send(job, { delaySeconds })
: env.JOBS.send(job));
}
}
await recordWebhookEvent(env, {
Expand Down
Loading
Loading